From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751693AbdLAAVS (ORCPT ); Thu, 30 Nov 2017 19:21:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:44068 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750842AbdLAAVR (ORCPT ); Thu, 30 Nov 2017 19:21:17 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 685092187C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Thu, 30 Nov 2017 19:21:15 -0500 From: Steven Rostedt To: Colin King Cc: Arnaldo Carvalho de Melo , "David S . Miller" , Daniel Borkmann , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools lib traceevent: fix an incorrect comparison with the literal "s64" Message-ID: <20171130192115.03d93d38@gandalf.local.home> In-Reply-To: <20171127161909.15565-1-colin.king@canonical.com> References: <20171127161909.15565-1-colin.king@canonical.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnaldo, Can you take this in your tree. And mark it for stable. Thanks! On Mon, 27 Nov 2017 16:19:09 +0000 Colin King wrote: > From: Colin Ian King > > I believe the comparison of the string 'type' with the literal string > "s64" is currently incorrect, it is missing a == 0 comparison as per > the other comparisons. > > Detected by cppcheck: > tools/lib/traceevent/event-parse.c:2209: (warning) The comparison > operator in 'strcmp(type,"s64") != 0' should maybe be '==' instead, > currently the expression 'strcmp(type,"u64") == 0' is redundant. > > Fixes: f7d82350e597 ("tools/events: Add files to create libtraceevent.a") Reviewed-by: Steven Rostedt (VMware) -- Steve > Signed-off-by: Colin Ian King > --- > tools/lib/traceevent/event-parse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c > index 7ce724fc0544..82b6c64c5b39 100644 > --- a/tools/lib/traceevent/event-parse.c > +++ b/tools/lib/traceevent/event-parse.c > @@ -2206,7 +2206,7 @@ eval_type_str(unsigned long long val, const char *type, int pointer) > return val & 0xffffffff; > > if (strcmp(type, "u64") == 0 || > - strcmp(type, "s64")) > + strcmp(type, "s64") == 0) > return val; > > if (strcmp(type, "s8") == 0)