From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751528AbdK3UBv (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Nov 2017 15:01:51 -0500
Received: from bombadil.infradead.org ([65.50.211.133]:46388 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751200AbdK3UBu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Nov 2017 15:01:50 -0500
Date: Thu, 30 Nov 2017 21:01:44 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "H . Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 15/24] x86/mm: Allow flushing for future ASID switches
Message-ID: <20171130200144.GL3165@worktop.lehotels.local>
References: <20171127104923.14378-1-mingo@kernel.org>
 <20171127104923.14378-16-mingo@kernel.org>
 <20171130154414.aekkjd26p3hxyqwa@hirez.programming.kicks-ass.net>
 <3ca0bea7-932a-6d91-a9b4-d07045d444f5@linux.intel.com>
 <20171130161844.v7ynfdggo6g7j5l5@hirez.programming.kicks-ass.net>
 <fd5bc34b-2bd2-13e2-b7e0-cf14e1c899f4@linux.intel.com>
 <CALCETrUhFKesaQrC07eMaCQHhvHaCcB9KtxeqMvN3cSfRXxRBg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCETrUhFKesaQrC07eMaCQHhvHaCcB9KtxeqMvN3cSfRXxRBg@mail.gmail.com>
User-Agent: Mutt/1.5.22.1 (2013-10-16)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 30, 2017 at 10:48:56AM -0800, Andy Lutomirski wrote:
> Should it be tlb_flush_shared_nonglobals_if_kernel_and_user_pagetables_are_separate()?

Its effectively invpcid_flush_all_other() or something like that. Of
course, its not invpcid based, so we should not name it such.

flush_asid_other() ?

> The whole idea that we can get away with ambiguous functions like
> __flush_tlb() seems to be much less true with KAISER.  I think we
> should maybe start getting rid of overly vague functions like this.

There is a lot of cleanup to be done for sure. I had to actually draw
pictures to untangle this stuff.