From: Lai Jiangshan <jiangshanlai@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Lai Jiangshan <jiangshanlai@gmail.com>, Tejun Heo <tj@kernel.org>
Subject: [PATCH] workqueue/hotplug: remove the workaround in rebind_workers()
Date: Fri, 1 Dec 2017 22:23:07 +0800 [thread overview]
Message-ID: <20171201142307.22352-1-jiangshanlai@gmail.com> (raw)
Sine the cpu/hotplug refactor is done, the hotplug
callbacks are called properly. So the workaround is
useless.
Signed-off-by: Lai Jiangshan <jiangshanlai@gmail.com>
---
kernel/workqueue.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 5c99beb8577d..528321bc45eb 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -4588,16 +4588,6 @@ static void rebind_workers(struct worker_pool *pool)
spin_lock_irq(&pool->lock);
- /*
- * XXX: CPU hotplug notifiers are weird and can call DOWN_FAILED
- * w/o preceding DOWN_PREPARE. Work around it. CPU hotplug is
- * being reworked and this can go away in time.
- */
- if (!(pool->flags & POOL_DISASSOCIATED)) {
- spin_unlock_irq(&pool->lock);
- return;
- }
-
pool->flags &= ~POOL_DISASSOCIATED;
for_each_pool_worker(worker, pool) {
--
2.13.6 (Apple Git-96)
next reply other threads:[~2017-12-01 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 14:23 Lai Jiangshan [this message]
2017-12-04 21:11 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201142307.22352-1-jiangshanlai@gmail.com \
--to=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®