From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: y2038@lists.linaro.org,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>, Dave Jiang <dave.jiang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HSI: cmt_speech: use timespec64 instead of timespec
Date: Fri, 1 Dec 2017 16:35:55 +0100 [thread overview]
Message-ID: <20171201153555.ab4iwigjgbhq6djz@earth> (raw)
In-Reply-To: <20171127114246.2559451-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]
Hi Arnd,
On Mon, Nov 27, 2017 at 12:42:34PM +0100, Arnd Bergmann wrote:
> struct timespec should no longer be used because of the y2038
> overflow problem. This code does not suffer from the overflow,
> but it's trivial to change it to use timespec64 without changing
> the interface, so let's do that.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Thanks, queued.
-- Sebastian
> drivers/hsi/clients/cmt_speech.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hsi/clients/cmt_speech.c b/drivers/hsi/clients/cmt_speech.c
> index 727f968ac1cb..05b80723d39d 100644
> --- a/drivers/hsi/clients/cmt_speech.c
> +++ b/drivers/hsi/clients/cmt_speech.c
> @@ -451,11 +451,11 @@ static void cs_hsi_read_on_control_complete(struct hsi_msg *msg)
> dev_dbg(&hi->cl->device, "Read on control: %08X\n", cmd);
> cs_release_cmd(msg);
> if (hi->flags & CS_FEAT_TSTAMP_RX_CTRL) {
> - struct timespec tspec;
> + struct timespec64 tspec;
> struct cs_timestamp *tstamp =
> &hi->mmap_cfg->tstamp_rx_ctrl;
>
> - ktime_get_ts(&tspec);
> + ktime_get_ts64(&tspec);
>
> tstamp->tv_sec = (__u32) tspec.tv_sec;
> tstamp->tv_nsec = (__u32) tspec.tv_nsec;
> --
> 2.9.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-12-01 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 11:42 Arnd Bergmann
2017-12-01 15:35 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201153555.ab4iwigjgbhq6djz@earth \
--to=sebastian.reichel@collabora.co.uk \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dave.jiang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®