From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752067AbdLARC4 (ORCPT ); Fri, 1 Dec 2017 12:02:56 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:40614 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751912AbdLARCg (ORCPT ); Fri, 1 Dec 2017 12:02:36 -0500 Date: Fri, 1 Dec 2017 17:01:49 +0000 From: Roman Gushchin To: Michal Hocko CC: , Johannes Weiner , Vladimir Davydov , Tetsuo Handa , Andrew Morton , David Rientjes , Tejun Heo , , , , , Subject: Re: [PATCH v13 6/7] mm, oom, docs: describe the cgroup-aware OOM killer Message-ID: <20171201170149.GB27436@castle.DHCP.thefacebook.com> References: <20171130152824.1591-1-guro@fb.com> <20171130152824.1591-7-guro@fb.com> <20171201084154.l7i3fxtxd4fzrq7s@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20171201084154.l7i3fxtxd4fzrq7s@dhcp22.suse.cz> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [2620:10d:c092:200::1:a6d6] X-ClientProxiedBy: DB6PR07CA0172.eurprd07.prod.outlook.com (2603:10a6:6:43::26) To CO1PR15MB1080.namprd15.prod.outlook.com (2a01:111:e400:7b66::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7e1a844a-83dc-48ed-1698-08d538dd4079 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603286);SRVR:CO1PR15MB1080; X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1080;3:vfpnwh9LKOfuXSQi9EzFJv9D1frIhSSrgVl8Aoc32Od5JkihbedoLy0kcR4BHF2Fz2z0UFxKscbfDmaMIuXL2EwMpPz47pMWo9WPoBpIsgFvEP0uvcw/nnoUJPUjsi97bOyLVyO6BnHaRiYi/tzyFv/UFP01uaWmlqes36Iw4CXNE7PjAInInspZlP16kT68dUip34z0kgE0g7hsswyVXIYKW5cf2XyL8dyh78y3e0s3TJ0KAfPjSulnG2CQVdlV;25:8MP4vXupQp6EgOiSmlHanJ3yGzzmrnjnWnwDu+XOfCEsznsqq6sGhBOGqtbicyd0FD528bkRxYCLnb3dlqeM7ZaPYj2a2zMdw5J2lsPYmoy8bdz1rtv+6q84BdRaIHvy5aS+kRDW/vzkpJS0ZipTuTP5S7KNSuLJett5JWRH6mLgnmxwq8Fzc1BSWXEwlmb+MGMVIArtpsOieECQ7GdnO4T9QBJ5yEG1Gm3cRR4uBB3Xx+acSPQVCD+ADsbijp1rZvX42aMF+qxPRNQ04Fa8nUuYD5l6cY2mH2XKbtLSaP0/WUWtcrIHpPskg2WcjJuVIScm6U5ZirM55J2bTKJWQQ==;31:gYSqJQUm3JwcyqfmIFlS90J1b2Mw6bYdoEbaXAo1b/fx5iomcYuF+yOvo0Ut88aGqVABEs9yIgxnnnuppp77RaxoSz1Jn3MWDluNA1zP55ZOKbLqwk8VgFG7V0qeqUPutfie+wqcg08mY4OTgInC+M8dxzOJU5BJU1nBqzI6/vAlQnkjIFgPr819E+IjGy6kEKCVmPNuVn/EAP4cl08ZncJprpnp8Mg73GPdQ4rL9Fo= X-MS-TrafficTypeDiagnostic: CO1PR15MB1080: X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1080;20:owPRzAaVwlPtYECVqzjMSvF08qk4YuL4HhMG/K8vO6Ma8ykWzls5CemHHl2FA56Hcd+IYn5MicmBePj+I7lc7lrvrkR1Z8gnCq/k+4hs6rnD2Fo0sq7nq4H8lTpCYQ30LAQlpRGpfLsFcYM68h3F04zTzOZYQwCY2kPk9Y/YddUo6E7X+rZGKLzqDaOXFd/Pkgdv4vugF3uDsniA+cbrnBRb/TUMz6nuNWOvrOPpI2STZNFApH3a/7LWKiyjxr7lZU9evpzBagCS0doSr8miSlVyR1iZfY3RY7WsnpFX8G0dvIU7eVxLoUVX0YCyEDzM0nJh2JwW6uOaeBGtk6WMnfd2AwQvu02v4S9WSr6n2/HwhETD59xhiHTOzkITyr2BIw1I/m0F9XzDAIg4mjyMlvvqis9hnIzJ6JP7s/vmdlu3931GZEMVxWgXqXViqxNsSurdc0F5lVFI9N/Em/5Xp8tgnTwHCA4paubV79gKHR9Axz9UO/icrGFkuRkvbj7X;4:KKNOozP5msHF1RbH2xkklLCBRYqHxg/wXxqS5A/7EWJdOe6lxPKRV0j7N1kQHojwF9FDxEtsVZUv+6dbbMUDNLbFqcT3e98a2dV7R9FycyJS28Wc+nH6DYQ+zZK+B5rWo+DxGeRqVpdaADFYsgRCbnB/9oF4tDAqOTq/2KUubaoWMNME5GIMefZrhuiUcZzmhAtgj8Te9L5Rm2KdfLkltJaZMDnuANOwzbfgRoQh8QUTvGbFrxcSTAynrb0jCyUxsdpk4pM+zY8lRtz1oGaD5BCqzrpCXdpT1EC2fwEENTvVFobPln1peaDtwpP+DtRd0gZEsjwHKG/AnRnx1wLVzwwuiMaExU2630UFpskobKMtvdOafByDQztO+DRJJ0HK X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(60795455431006)(9452136761055)(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(11241501159)(6040450)(2401047)(8121501046)(5005006)(3231022)(93006095)(93001095)(3002001)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(20161123562025)(6072148)(201708071742011);SRVR:CO1PR15MB1080;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CO1PR15MB1080; X-Forefront-PRVS: 05087F0C24 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(366004)(346002)(376002)(189002)(24454002)(199003)(377424004)(316002)(52116002)(52396003)(5660300001)(54906003)(81156014)(81166006)(53546010)(105586002)(106356001)(7696005)(68736007)(229853002)(6666003)(58126008)(76176011)(86362001)(2950100002)(478600001)(7416002)(6916009)(305945005)(7736002)(8676002)(8936002)(54356011)(50466002)(25786009)(16586007)(47776003)(9686003)(83506002)(97736004)(189998001)(6116002)(39060400002)(1076002)(6246003)(23726003)(53936002)(6506006)(2906002)(55016002)(4326008)(33656002)(101416001)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:CO1PR15MB1080;H:castle.DHCP.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CO1PR15MB1080;23:bvmMLwCgH06k7tn9Nh54U5axWGJL9Kq3xGXiKngoQ?= =?us-ascii?Q?YGRvVEJM1QoKsDvmNnEZfTZrqhk3IUj9IInxOZQ2aWS4+DqB2C62DLX7qK08?= =?us-ascii?Q?qcwoJnPnlFnGRc7l+oUP8ksTj7QR29Sxoqunp8lkQRQaazQp1PFSsgoj/W/J?= =?us-ascii?Q?zguXTiCZ7UZpw5pi865HvLL5NlpVfGfQcKJwOz0ObAxwZa5ptAPHF5ec3Shw?= =?us-ascii?Q?khbprjqXXWcdhUKouE2hqDehzzVQKSkKtVnVNXefHauCTDoWIUHgIQd696Hu?= =?us-ascii?Q?Bc/IeDOoIXgff/x8TTE9RtIuth4JiDzDZtEsIQK75vLK3a/MTl5kpIWyl37p?= =?us-ascii?Q?7m6eFKEMnQfPuEKDTrsOl4s/qeAi9yVR6TVKh85c9du1YJkyiQbzT6IgUYEY?= =?us-ascii?Q?sSwOhIefOfCqG+Fn48e8lf6+VsdHdJgSoxipulH/3M0KSIPvhdV3d1Pbbzln?= =?us-ascii?Q?y3o991FJJpViPfvLt+nJ+aqVQgusc12yqAhgs4zkUPnWL2i4pac1JqdjsDz1?= =?us-ascii?Q?C0gx+kAJpK4+28M9D3hO7Hvb7ZvKBIndTqpKFDZzeAd0nMpP6OQvDTtSI7nL?= =?us-ascii?Q?Jq+n/+0aF76vs9TFXsMObLmYfiR/wn46Fn6dnteaTFRMPAvCk3b8yPyBP5FX?= =?us-ascii?Q?iaBaeRUZtfpz9cfi89gqOrNn9ErHMJYWtQm+c8vtEJPfG94aAeXkqNxNlIqQ?= =?us-ascii?Q?ictK3UsWONydUBFmo36Wa5ubBoUgaMQ5c38oosPewNMmVEp2cKPAZgRf37Xo?= =?us-ascii?Q?NeqmYoFeMDXUnjNTp0Jv4vRUf9iMDm7cNjAMUf84vSXoLr3gmcwjxhzd7SD/?= =?us-ascii?Q?tUbNIoeyMyLcsBuGmcWJElLCWLxT1oPIYht0qsaRfXYu2NgTCUHdYvAlYHk1?= =?us-ascii?Q?5tWH1nvo9Q9VVP2L62TRIXvOatCFX9i9Ux0l2j6FTaenwsvSyEORwKnoUzzw?= =?us-ascii?Q?NNAiQEMe0c521LgtEwX0kNwBpIwRnrvQIVD0EpYvBIrQN1xX0JA+EyJPndq0?= =?us-ascii?Q?wXmb/6OAbWJhWyOSTSfWi1ediULaQhyaAbhtrYlGrW6iQBWgTxAQ1mJEvB0f?= =?us-ascii?Q?3NBYs+Ifq60Xgua1seEFyN2pPkGdY2U6WkbwVRBhcTAjzCCi32ql1LnRZZQ2?= =?us-ascii?Q?MhX7gzuUjdhLQkTNCrwTJYX4SLmjwVRJuu0/TyBkLRxihSrBlt10VXraQPRF?= =?us-ascii?Q?iLUm1saBmKAbmut1IV5g8RRjpQDkMi4zXgNGYh+zUYYBIVDOpEfCJFy15Ch1?= =?us-ascii?Q?Ybe3U6ojjOl5izVmeq7QYmSSFdKUhwiIo6j0vXr7hulrJcyC28jsZ9s1Tkvr?= =?us-ascii?B?dz09?= X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1080;6:xv7oTmEUx2mbVCEZo0FBKxgGQSMl9JxlfwvdiocVS+Mgq0m/nIPap2rBQMhaai0Z/yIQswQKxH46nbspvuC6uTVcKhSrOx3DDprHtYlNvtjYV0LJmClFm8QMJ0t2BQ4qCVLcOomtEQZNIouJK6b57vqtnLyQ6Rar4raXViToEAvrMNz7eV/eU/ydZiE4mKnHWyEmTSVnBpvrE9qZkC9eVzQB+LbZeTB9Q1Rsb1HSfVFqVWFoxNLGRdb3tWcpVo89ykfbY4eL1Gu6R7qaCc/eYpVo3DHuT/9Jt+ZG7sN6isiR1BegbPvf+f+jfTDHs79yctqOAMMbes6bDK4ykmnyLCD8tkbVskP6KFQKW+7abU8=;5:l0j5/Kf/ls1Jo6Nl3lGDpw0iOxT8mRLZl6Pe1lwH+U4fOXxJdDJSQCHzWiA7gD7+VooaGyuZV8GPh4wSE9gr1MKXAyDJi8UE6JRVSqWiT64fn+BTTd8Ba/beUzO7InyvS4wo51uhXsXd4UF5Y2Fl5w0xUMM4RHEWj59nURDivbQ=;24:vek7YtqU+eKNDolbfBD0/bk2EeZ0oohglN8D90tp5D/EeCU8cZUvSYBBXD1pRDeZaR78bVpiUj4lwD7fa6VTHUkY3Pfx/aeh1KBM3S/QPzk=;7:HbJHXd9yVdYnGo60avvqO72223vU+GIqQC/DmusunUOMtnApgFlOMNqhDs+RorZy29jx+Ata1Eg7/FWGf4Xz/ZXtYyWlRbbH6himeDwU/RVcaEilRMaqIr6Oqk4kIxAvSKgjZ9YcyCkrySzz34uesDLGO/Kx7tg194slCCSKLhe0lq+3PA3OBDAtzjFtqiFPSR08/ENzhLDmQ2nX1dwhL3t84uUikyBIyl+RbS6oTzkyAtBGa3/Rf3EB4YAISTWS SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB1080;20:RchlttBzK7odnn5NpxBfhlw8WWLHftRNyHRd597nZaTZFZqF8iHq+S1IdesccCF09qUI6W8as1c+0T9BpBc3DO/hdSB22KDTQT0PQaAQZAoPYV7QXqQRHVE3lyr4XO3WERK9b0bAztGLRZPhOzL2jlltfhz+VPsNbJERgha1FXY= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2017 17:02:03.7147 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7e1a844a-83dc-48ed-1698-08d538dd4079 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR15MB1080 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-01_04:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 01, 2017 at 09:41:54AM +0100, Michal Hocko wrote: > On Thu 30-11-17 15:28:23, Roman Gushchin wrote: > > @@ -1229,6 +1252,41 @@ to be accessed repeatedly by other cgroups, it may make sense to use > > POSIX_FADV_DONTNEED to relinquish the ownership of memory areas > > belonging to the affected files to ensure correct memory ownership. > > > > +OOM Killer > > +~~~~~~~~~~ > > + > > +Cgroup v2 memory controller implements a cgroup-aware OOM killer. > > +It means that it treats cgroups as first class OOM entities. > > This should mention groupoom mount option to enable this functionality. > > Other than that looks ok to me > Acked-by: Michal Hocko > -- > Michal Hocko > SUSE Labs >>From 1d9c87128897ee7f27f9651d75b80f73985373e8 Mon Sep 17 00:00:00 2001 From: Roman Gushchin Date: Fri, 1 Dec 2017 15:34:59 +0000 Subject: [PATCH] mm, oom, docs: document groupoom mount option Add a note that cgroup-aware OOM logic is disabled by default and describe how to enable it. Signed-off-by: Roman Gushchin Cc: Andrew Morton Cc: Johannes Weiner Cc: Michal Hocko Cc: Vladimir Davydov Cc: Tejun Heo Cc: kernel-team@fb.com Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org --- Documentation/cgroup-v2.txt | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Documentation/cgroup-v2.txt b/Documentation/cgroup-v2.txt index c80a147f94b7..ff8e92db636d 100644 --- a/Documentation/cgroup-v2.txt +++ b/Documentation/cgroup-v2.txt @@ -1049,6 +1049,9 @@ PAGE_SIZE multiple when read back. and will never kill the unkillable task, even if memory.oom_group is set. + If cgroup-aware OOM killer is not enabled, ENOTSUPP error + is returned on attempt to access the file. + memory.events A read-only flat-keyed file which exists on non-root cgroups. The following entries are defined. Unless specified @@ -1258,6 +1261,12 @@ OOM Killer Cgroup v2 memory controller implements a cgroup-aware OOM killer. It means that it treats cgroups as first class OOM entities. +Cgroup-aware OOM logic is turned off by default and requires +passing the "groupoom" option on mounting cgroupfs. It can also +by remounting cgroupfs with the following command:: + + # mount -o remount,groupoom $MOUNT_POINT + Under OOM conditions the memory controller tries to make the best choice of a victim, looking for a memory cgroup with the largest memory footprint, considering leaf cgroups and cgroups with the -- 2.14.3