From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751941AbdLBBVN (ORCPT ); Fri, 1 Dec 2017 20:21:13 -0500 Received: from mail-pl0-f68.google.com ([209.85.160.68]:40061 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751604AbdLBBVL (ORCPT ); Fri, 1 Dec 2017 20:21:11 -0500 X-Google-Smtp-Source: AGs4zMaCO3X+bSPQDNdEXjBMaE7cwkwX3WOx+ILZadu0NLWQFBZh6npIXApnKEASzrod5ME8SasJQQ== Date: Fri, 1 Dec 2017 17:21:08 -0800 From: Moritz Fischer To: Alexey Khoroshilov Cc: Alan Tull , Moritz Fischer , linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] fpga: socfpga-a10: disable clk on error in socfpga_a10_fpga_probe() Message-ID: <20171202012108.x5js74t73f3wkpem@derp-derp.lan> References: <1512159984-23948-1-git-send-email-khoroshilov@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512159984-23948-1-git-send-email-khoroshilov@ispras.ru> User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexey, On Fri, Dec 01, 2017 at 11:26:24PM +0300, Alexey Khoroshilov wrote: > If fpga_mgr_register() fails, a clock is left undisabled. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Reviewed-by: Moritz Fischer > --- > drivers/fpga/socfpga-a10.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/fpga/socfpga-a10.c b/drivers/fpga/socfpga-a10.c > index f8770af0f6b5..a46e343a5b72 100644 > --- a/drivers/fpga/socfpga-a10.c > +++ b/drivers/fpga/socfpga-a10.c > @@ -519,8 +519,14 @@ static int socfpga_a10_fpga_probe(struct platform_device *pdev) > return -EBUSY; > } > > - return fpga_mgr_register(dev, "SoCFPGA Arria10 FPGA Manager", > + ret = fpga_mgr_register(dev, "SoCFPGA Arria10 FPGA Manager", > &socfpga_a10_fpga_mgr_ops, priv); > + if (ret) { > + clk_disable_unprepare(priv->clk); > + return ret; > + } > + > + return 0; > } > > static int socfpga_a10_fpga_remove(struct platform_device *pdev) > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fpga" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Thanks for your patch, Moritz