From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751908AbdLBOV4 (ORCPT ); Sat, 2 Dec 2017 09:21:56 -0500 Received: from mx2.suse.de ([195.135.220.15]:36174 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751687AbdLBOVz (ORCPT ); Sat, 2 Dec 2017 09:21:55 -0500 Date: Sat, 2 Dec 2017 15:21:48 +0100 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] x86/mce/AMD: Define function to get SMCA bank type Message-ID: <20171202142148.mnn7x3ax2ix3gpwp@pd.tnic> References: <20171201155034.39206-1-Yazen.Ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171201155034.39206-1-Yazen.Ghannam@amd.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 01, 2017 at 09:50:33AM -0600, Yazen Ghannam wrote: > From: Yazen Ghannam > > Scalable MCA systems have various types of banks. The bank's type can > determine how we handle errors from it. For example, if a bank represents > a UMC then we will need to convert its address from a normalized address > to a system physical address before handling the error. > > Define an exported function to return a bank's SMCA type. > > Signed-off-by: Yazen Ghannam > --- > arch/x86/include/asm/mce.h | 1 + > arch/x86/kernel/cpu/mcheck/mce_amd.c | 11 +++++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h > index b1e8d8db921f..9ab8bf32e61c 100644 > --- a/arch/x86/include/asm/mce.h > +++ b/arch/x86/include/asm/mce.h > @@ -376,6 +376,7 @@ struct smca_bank { > extern struct smca_bank smca_banks[MAX_NR_BANKS]; > > extern const char *smca_get_long_name(enum smca_bank_types t); > +extern unsigned int smca_get_bank_type(struct mce *m); > > extern int mce_threshold_create_device(unsigned int cpu); > extern int mce_threshold_remove_device(unsigned int cpu); > diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c b/arch/x86/kernel/cpu/mcheck/mce_amd.c > index a38ab1fa53a2..bc0510a4f6c0 100644 > --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c > +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c > @@ -110,6 +110,17 @@ const char *smca_get_long_name(enum smca_bank_types t) > } > EXPORT_SYMBOL_GPL(smca_get_long_name); > > +unsigned int smca_get_bank_type(struct mce *m) > +{ > + struct smca_bank bank = smca_banks[m->bank]; > + > + if (!bank.hwid) > + return N_SMCA_BANK_TYPES; > + > + return bank.hwid->bank_type; > +} > +EXPORT_SYMBOL_GPL(smca_get_bank_type); Why are you exporting it if it is used in mce_amd.c only anyway? -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --