From: alexander.levin@verizon.com
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: Stephen Bates <sbates@raithlin.com>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
Will Deacon <will.deacon@arm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
alexander.levin@verizon.com
Subject: [PATCH AUTOSEL for 4.14 19/64] lib/genalloc.c: make the avail variable an atomic_long_t
Date: Sat, 2 Dec 2017 15:51:22 +0000 [thread overview]
Message-ID: <20171202155101.7573-19-alexander.levin@verizon.com> (raw)
In-Reply-To: <20171202155101.7573-1-alexander.levin@verizon.com>
From: Stephen Bates <sbates@raithlin.com>
[ Upstream commit 36a3d1dd4e16bcd0d2ddfb4a2ec7092f0ae0d931 ]
If the amount of resources allocated to a gen_pool exceeds 2^32 then the
avail atomic overflows and this causes problems when clients try and
borrow resources from the pool. This is only expected to be an issue on
64 bit systems.
Add the <linux/atomic.h> header to pull in atomic_long* operations. So
that 32 bit systems continue to use atomic32_t but 64 bit systems can
use atomic64_t.
Link: http://lkml.kernel.org/r/1509033843-25667-1-git-send-email-sbates@raithlin.com
Signed-off-by: Stephen Bates <sbates@raithlin.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Reviewed-by: Daniel Mentz <danielmentz@google.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Will Deacon <will.deacon@arm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
---
include/linux/genalloc.h | 3 ++-
lib/genalloc.c | 10 +++++-----
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/include/linux/genalloc.h b/include/linux/genalloc.h
index 6dfec4d638df..872f930f1b06 100644
--- a/include/linux/genalloc.h
+++ b/include/linux/genalloc.h
@@ -32,6 +32,7 @@
#include <linux/types.h>
#include <linux/spinlock_types.h>
+#include <linux/atomic.h>
struct device;
struct device_node;
@@ -71,7 +72,7 @@ struct gen_pool {
*/
struct gen_pool_chunk {
struct list_head next_chunk; /* next chunk in pool */
- atomic_t avail;
+ atomic_long_t avail;
phys_addr_t phys_addr; /* physical starting address of memory chunk */
unsigned long start_addr; /* start address of memory chunk */
unsigned long end_addr; /* end address of memory chunk (inclusive) */
diff --git a/lib/genalloc.c b/lib/genalloc.c
index 144fe6b1a03e..ca06adc4f445 100644
--- a/lib/genalloc.c
+++ b/lib/genalloc.c
@@ -194,7 +194,7 @@ int gen_pool_add_virt(struct gen_pool *pool, unsigned long virt, phys_addr_t phy
chunk->phys_addr = phys;
chunk->start_addr = virt;
chunk->end_addr = virt + size - 1;
- atomic_set(&chunk->avail, size);
+ atomic_long_set(&chunk->avail, size);
spin_lock(&pool->lock);
list_add_rcu(&chunk->next_chunk, &pool->chunks);
@@ -304,7 +304,7 @@ unsigned long gen_pool_alloc_algo(struct gen_pool *pool, size_t size,
nbits = (size + (1UL << order) - 1) >> order;
rcu_read_lock();
list_for_each_entry_rcu(chunk, &pool->chunks, next_chunk) {
- if (size > atomic_read(&chunk->avail))
+ if (size > atomic_long_read(&chunk->avail))
continue;
start_bit = 0;
@@ -324,7 +324,7 @@ retry:
addr = chunk->start_addr + ((unsigned long)start_bit << order);
size = nbits << order;
- atomic_sub(size, &chunk->avail);
+ atomic_long_sub(size, &chunk->avail);
break;
}
rcu_read_unlock();
@@ -390,7 +390,7 @@ void gen_pool_free(struct gen_pool *pool, unsigned long addr, size_t size)
remain = bitmap_clear_ll(chunk->bits, start_bit, nbits);
BUG_ON(remain);
size = nbits << order;
- atomic_add(size, &chunk->avail);
+ atomic_long_add(size, &chunk->avail);
rcu_read_unlock();
return;
}
@@ -464,7 +464,7 @@ size_t gen_pool_avail(struct gen_pool *pool)
rcu_read_lock();
list_for_each_entry_rcu(chunk, &pool->chunks, next_chunk)
- avail += atomic_read(&chunk->avail);
+ avail += atomic_long_read(&chunk->avail);
rcu_read_unlock();
return avail;
}
--
2.11.0
next prev parent reply other threads:[~2017-12-02 16:24 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 15:51 [PATCH AUTOSEL for 4.14 01/64] irqchip/qcom: Fix u32 comparison with value less than zero alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 03/64] net/smc: use sk_rcvbuf as start for rmb creation alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 02/64] net: ipv6: Fixup device for anycast routes during copy alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 04/64] kbuild: pkg: use --transform option to prefix paths in tar alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 07/64] net: qmi_wwan: add Quectel BG96 2c7c:0296 alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 08/64] apparmor: fix leak of null profile name if profile allocation fails alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 06/64] powerpc/perf: Fix pmu_count to count only nest imc pmus alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 05/64] coccinelle: fix parallel build with CHECK=scripts/coccicheck alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 11/64] tun: fix rcu_read_lock imbalance in tun_build_skb alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 09/64] x86/mpx/selftests: Fix up weird arrays alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 10/64] mac80211_hwsim: Fix memory leak in hwsim_new_radio_nl() alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 12/64] gre6: use log_ecn_error module parameter in ip6_tnl_rcv() alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 13/64] tcp: when scheduling TLP, time of RTO should account for current ACK alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 14/64] route: also update fnhe_genid when updating a route cache alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 15/64] route: update fnhe_expires for redirect when the fnhe exists alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 16/64] rsi: fix memory leak on buf and usb_reg_buf alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 17/64] drivers/rapidio/devices/rio_mport_cdev.c: fix resource leak in error handling path in 'rio_dma_transfer()' alexander.levin
2017-12-02 15:51 ` alexander.levin [this message]
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 20/64] dynamic-debug-howto: fix optional/omitted ending line number to be LARGE instead of 0 alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 18/64] pipe: match pipe_max_size data type with procfs alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 21/64] NFS: Fix a typo in nfs_rename() alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 22/64] sunrpc: Fix rpc_task_begin trace point alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 23/64] nfp: inherit the max_mtu from the PF netdev alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 25/64] xfs: fix forgotten rcu read unlock when skipping inode reclaim alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 24/64] nfp: fix flower offload metadata flag usage alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 27/64] block: wake up all tasks blocked in get_request() alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 28/64] sparc64/mm: set fields in deferred pages alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 26/64] dt-bindings: usb: fix reg-property port-number range alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 30/64] slub: fix sysfs duplicate filename creation when slub_debug=O alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 29/64] zsmalloc: calling zs_map_object() from irq is a bug alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 31/64] sctp: do not free asoc when it is already dead in sctp_sendmsg alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 32/64] sctp: use the right sk after waking up from wait_buf sleep alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 34/64] geneve: fix fill_info when link down alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 33/64] fcntl: don't leak fd reference when fixup_compat_flock fails alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 35/64] bpf: fix lockdep splat alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 36/64] ipv6: set all.accept_dad to 0 by default alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 37/64] clk: stm32h7: fix test of clock config alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 38/64] clk: sunxi-ng: a83t: Fix i2c buses bits alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 40/64] clk: uniphier: fix DAPLL2 clock rate of Pro5 alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 39/64] clk: qcom: common: fix legacy board-clock registration alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 41/64] clk: hi3660: fix incorrect uart3 clock freqency alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 42/64] mailbox: mailbox-test: don't rely on rx_buffer content to signal data ready alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 45/64] jump_label: Invoke jump_label_test() via early_initcall() alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 43/64] kbuild: rpm-pkg: fix jobserver unavailable warning alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 46/64] tls: Use kzalloc for aead_request allocation alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 44/64] atm: horizon: Fix irq release error alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 47/64] xfrm: Copy policy family in clone_policy alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 49/64] bnxt_re: changing the ip address shouldn't affect new connections alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 48/64] f2fs: fix to clear FI_NO_PREALLOC alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 50/64] IB/mlx4: Increase maximal message size under UD QP alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 51/64] IB/mlx5: Assign send CQ and recv CQ of UMR QP alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 53/64] afs: Connect up the CB.ProbeUuid alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 52/64] afs: Fix total-length calculation for multiple-page send alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 55/64] powerpc/powernv/idle: Round up latency and residency values alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 54/64] kbuild: do not call cc-option before KBUILD_CFLAGS initialization alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 56/64] ipvlan: fix ipv6 outbound device alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 57/64] ide: ide-atapi: fix compile error with defining macro DEBUG alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 58/64] blk-mq: Avoid that request queue removal can trigger list corruption alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 59/64] nvmet-rdma: update queue list during ib_device removal alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 61/64] audit: ensure that 'audit=1' actually enables audit for PID 1 alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 62/64] dm raid: fix panic when attempting to force a raid to sync alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 60/64] audit: Allow auditd to set pid to 0 to end auditing alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 63/64] md: free unused memory after bitmap resize alexander.levin
2017-12-02 15:51 ` [PATCH AUTOSEL for 4.14 64/64] RDMA/cxgb4: Annotate r2 and stag as __be32 alexander.levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171202155101.7573-19-alexander.levin@verizon.com \
--to=alexander.levin@verizon.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sbates@raithlin.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®