mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: alexander.levin@verizon.com
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
	Anna Schumaker <Anna.Schumaker@Netapp.com>,
	alexander.levin@verizon.com
Subject: [PATCH AUTOSEL for 3.18 05/15] NFS: Fix a typo in nfs_rename()
Date: Sat, 2 Dec 2017 15:53:33 +0000	[thread overview]
Message-ID: <20171202155324.7846-5-alexander.levin@verizon.com> (raw)
In-Reply-To: <20171202155324.7846-1-alexander.levin@verizon.com>

From: Trond Myklebust <trond.myklebust@primarydata.com>

[ Upstream commit d803224c84be067754db7fa58a93f36f61566493 ]

On successful rename, the "old_dentry" is retained and is attached to
the "new_dir", so we need to call nfs_set_verifier() accordingly.

Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
---
 fs/nfs/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 43d63a4d9a92..08b8844544d7 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -2062,7 +2062,7 @@ out:
 		if (new_inode != NULL)
 			nfs_drop_nlink(new_inode);
 		d_move(old_dentry, new_dentry);
-		nfs_set_verifier(new_dentry,
+		nfs_set_verifier(old_dentry,
 					nfs_save_change_attribute(new_dir));
 	} else if (error == -ENOENT)
 		nfs_dentry_handle_enoent(old_dentry);
-- 
2.11.0

  parent reply	other threads:[~2017-12-02 15:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-02 15:53 [PATCH AUTOSEL for 3.18 01/15] route: also update fnhe_genid when updating a route cache alexander.levin
2017-12-02 15:53 ` [PATCH AUTOSEL for 3.18 02/15] route: update fnhe_expires for redirect when the fnhe exists alexander.levin
2017-12-02 15:53 ` [PATCH AUTOSEL for 3.18 04/15] dynamic-debug-howto: fix optional/omitted ending line number to be LARGE instead of 0 alexander.levin
2017-12-02 15:53 ` [PATCH AUTOSEL for 3.18 03/15] lib/genalloc.c: make the avail variable an atomic_long_t alexander.levin
2017-12-02 15:53 ` alexander.levin [this message]
2017-12-02 15:53 ` [PATCH AUTOSEL for 3.18 06/15] sunrpc: Fix rpc_task_begin trace point alexander.levin
2017-12-02 15:53 ` [PATCH AUTOSEL for 3.18 09/15] sctp: use the right sk after waking up from wait_buf sleep alexander.levin
2017-12-02 15:53 ` [PATCH AUTOSEL for 3.18 07/15] sparc64/mm: set fields in deferred pages alexander.levin
2017-12-02 15:53 ` [PATCH AUTOSEL for 3.18 08/15] sctp: do not free asoc when it is already dead in sctp_sendmsg alexander.levin
2017-12-02 15:53 ` [PATCH AUTOSEL for 3.18 11/15] xfrm: Copy policy family in clone_policy alexander.levin
2017-12-02 15:53 ` [PATCH AUTOSEL for 3.18 10/15] atm: horizon: Fix irq release error alexander.levin
2017-12-02 15:53 ` [PATCH AUTOSEL for 3.18 12/15] IB/mlx4: Increase maximal message size under UD QP alexander.levin
2017-12-02 15:53 ` [PATCH AUTOSEL for 3.18 14/15] afs: Connect up the CB.ProbeUuid alexander.levin
2017-12-02 15:53 ` [PATCH AUTOSEL for 3.18 13/15] IB/mlx5: Assign send CQ and recv CQ of UMR QP alexander.levin
2017-12-02 15:53 ` [PATCH AUTOSEL for 3.18 15/15] audit: ensure that 'audit=1' actually enables audit for PID 1 alexander.levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171202155324.7846-5-alexander.levin@verizon.com \
    --to=alexander.levin@verizon.com \
    --cc=Anna.Schumaker@Netapp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®