From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753871AbdLDJKh (ORCPT ); Mon, 4 Dec 2017 04:10:37 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:45433 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753551AbdLDJKb (ORCPT ); Mon, 4 Dec 2017 04:10:31 -0500 X-Google-Smtp-Source: AGs4zMZagJ/xvPpbLIdtuDn1a7IGkFJ142MwJizxfS3SQYXTtrxtQnnDqJfJ1ftDu2LPYfZCGcn8PA== Date: Mon, 4 Dec 2017 09:10:26 +0000 From: Lee Jones To: Gwendal Grignou Cc: Guenter Roeck , Thierry Escande , Benson Leung , Enric Balletbo i Serra , linux-kernel Subject: Re: [PATCH v2 2/2] cros_ec: Move cros_ec_dev module to drivers/mfd Message-ID: <20171204091026.yo7rbc3hwp3ygae7@dell> References: <1511194526-3729-1-git-send-email-thierry.escande@collabora.com> <1511194526-3729-3-git-send-email-thierry.escande@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 01 Dec 2017, Gwendal Grignou wrote: > Reviewed-by: Gwendal Grignou Can you please reply inline (where Guenter did is perfect) and snip the rest please? Top posting is to be strongly discouraged. > On Thu, Nov 30, 2017 at 12:50 PM, Guenter Roeck wrote: > > On Mon, Nov 20, 2017 at 8:15 AM, Thierry Escande > > wrote: > >> The cros_ec_dev module is responsible for registering the MFD devices > >> attached to the ChromeOS EC. This patch moves this module to drivers/mfd > >> so calls to mfd_add_devices() are not done from outside the MFD subtree > >> anymore. > >> > >> Signed-off-by: Thierry Escande > > > > Tested-by: Guenter Roeck > > > >> --- > >> drivers/mfd/Kconfig | 10 + > >> drivers/mfd/Makefile | 1 + > >> drivers/mfd/cros_ec_dev.c | 552 ++++++++++++++++++++++++++++ > >> drivers/mfd/cros_ec_dev.h | 52 +++ > >> drivers/platform/chrome/Kconfig | 10 - > >> drivers/platform/chrome/Makefile | 1 - > >> drivers/platform/chrome/cros_ec_debugfs.c | 3 - > >> drivers/platform/chrome/cros_ec_debugfs.h | 27 -- > >> drivers/platform/chrome/cros_ec_dev.c | 553 ----------------------------- > >> drivers/platform/chrome/cros_ec_dev.h | 52 --- > >> drivers/platform/chrome/cros_ec_lightbar.c | 2 - > >> drivers/platform/chrome/cros_ec_sysfs.c | 2 - > >> include/linux/mfd/cros_ec.h | 4 + > >> 13 files changed, 619 insertions(+), 650 deletions(-) > >> create mode 100644 drivers/mfd/cros_ec_dev.c > >> create mode 100644 drivers/mfd/cros_ec_dev.h > >> delete mode 100644 drivers/platform/chrome/cros_ec_debugfs.h > >> delete mode 100644 drivers/platform/chrome/cros_ec_dev.c > >> delete mode 100644 drivers/platform/chrome/cros_ec_dev.h -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog