From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752545AbdLDJhJ (ORCPT ); Mon, 4 Dec 2017 04:37:09 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:48336 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752479AbdLDJhH (ORCPT ); Mon, 4 Dec 2017 04:37:07 -0500 X-Greylist: delayed 4953 seconds by postgrey-1.27 at vger.kernel.org; Mon, 04 Dec 2017 04:37:07 EST Date: Mon, 4 Dec 2017 12:36:39 +0300 From: Dan Carpenter To: Gilad Ben-Yossef Cc: Greg Kroah-Hartman , linux-crypto@vger.kernel.org, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, Ofir Drang Subject: Re: [PATCH 01/10] staging: ccree: remove inline qualifiers Message-ID: <20171204093639.7ctulxb4v2htqbmj@mwanda> References: <1512309503-29766-1-git-send-email-gilad@benyossef.com> <1512309503-29766-2-git-send-email-gilad@benyossef.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512309503-29766-2-git-send-email-gilad@benyossef.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8734 signatures=668637 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712040139 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 03, 2017 at 01:58:12PM +0000, Gilad Ben-Yossef wrote: > The ccree drivers was marking a lot of big functions in C file as > static inline for no good reason. Remove the inline qualifier from > any but the few truly single line functions. > The compiler is free to ignore inline hints... It probably would make single line functions inline anyway. regards, dan carpenter