From: Patrick Bellasi <patrick.bellasi@arm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Joel Fernandes <joelaf@google.com>
Subject: Re: [PATCH] tracing: Fix trace_preempt_{on,off} for !CONFIG_DEBUG_PREEMPT builds
Date: Mon, 4 Dec 2017 11:44:51 +0000 [thread overview]
Message-ID: <20171204114451.GJ31247@e110439-lin> (raw)
In-Reply-To: <20171204062602.4f1ea332@vmware.local.home>
On 04-Dec 06:26, Steven Rostedt wrote:
> On Mon, 4 Dec 2017 09:46:42 +0000
> Patrick Bellasi <patrick.bellasi@arm.com> wrote:
>
> > The new preempt enable/disable events introduced by:
> >
> > d59158162 tracing: Add support for preempt and irq enable/disable events
> >
> > are defined only for CONFIG_DEBUG_PREEMPT kernels when the
> > CONFIG_PREEMPTIRQ_EVENTS support, introduced by the above patch, is
> > enabled.
> >
> > These events are generated within by trace_preempt_{on,off} calls,
> > which are part of the the "Preemption-off Latency Tracer"
> > (CONFIG_PREEMPT_TRACER).
> >
> > Currently these calls are (correctly) generated on CONFIG_PREEMPT_TRACER
> > even when the kernel is !CONFIG_DEBUG_PREEMPT configured. Thus leading
> > to an undefined reference to the new trace events.
> >
> > Let's ensure that we always have an (eventually) empty definition of the
> > events for CONFIG_PREEMPTIRQ_EVENTS kernels.
> >
> > This patch will ensure that the additional preempt enabled/disable
> > events are generated only when we have both:
> > CONFIG_PREEMPT_TRACER && CONFIG_DEBUG_PREEMPT
> >
> > Signed-off-by: Patrick Bellasi <patrick.bellasi@arm.com>
>
> Thanks, but you're the third person to send me a fix for this. I have
> the first fixed applied to my code based off of 4.14-rc1 but that
> branch breaks my tests. I was waiting for rc2 to come out (which just
> happened), to rebase on and run my tests. I'll do that now.
No problems, I did not notice previous fixes.
> Thanks,
>
> -- Steve
Cheers Patrick
--
#include <best/regards.h>
Patrick Bellasi
next prev parent reply other threads:[~2017-12-04 11:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 9:46 Patrick Bellasi
2017-12-04 11:26 ` Steven Rostedt
2017-12-04 11:44 ` Patrick Bellasi [this message]
2017-12-05 16:41 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204114451.GJ31247@e110439-lin \
--to=patrick.bellasi@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome