From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753922AbdLDOp5 (ORCPT ); Mon, 4 Dec 2017 09:45:57 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:60057 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752529AbdLDOpy (ORCPT ); Mon, 4 Dec 2017 09:45:54 -0500 From: Arnd Bergmann To: Jan-Simon Moeller , Richard Purdie , Jacek Anaszewski , Pavel Machek Cc: Arnd Bergmann , Arvind Yadav , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] leds: blinkm: avoid uninitialized data use Date: Mon, 4 Dec 2017 15:45:29 +0100 Message-Id: <20171204144538.304782-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:1g34bAAMOUJ+YFhSOH4AF+xe98Nhw0sOHTmqXKMmSbRn5N0fouy horvYRTmFEDqa46CLMQlPxq3ONDs233k4V20TebCC2Fo1mInMd4XXK4qrIeenhD9JCoWL6r FCcvX93rMHnShqjf183irOk7fCapVgS6WXMbyFR4gqLAfFsJrjTMZlCSqDDpJsb+A7kQ71I khGVYIk4A/Gp+MeZpChRw== X-UI-Out-Filterresults: notjunk:1;V01:K0:wxn6+XnGgcQ=:BiKzqswLO6lD7nzqvtSy1n UeCpTLUa0uKsbjlcbSJ99J2Ca1mqr3p4yogxUTes1PjvXZIfsoD+k0dx7K2g2Jeyc3PIIEpDx Uh88OHZeeInE7Hkf//GLYnzbgz0Kpd9PrUYt20ZkTJJtnRRe1y5rwAxuH33r1vP414D/o+8yE yi45pzd3/nQ8s55YYK6kGLvhx1tEdeMFFB8CP8M9DG3VnslVmfQPZMlNDMJLBg+FjlPattWH2 LyHx3X0kKE49j9diqSezCr09nA632xCstRJp5LVbph76Jg3nH9j4iFEeaZ0T7Ilt8S0JItUuy zNvzy9YimdPTb4mlIrHvEygHBwIgz/JAPye4aHO+uMDsblRaOiVejgbwx+BgRdbaQcJbXNxnj BbTAIh2fMp5e8PFtHaImAAYkk0G7U9T6xDPC1qTzSIJmvNjssehrRjOSCSHUSl2ZwQu684ZF4 VBbi4i1E4OuRu7ViwfJMfVkV9p1NWC47+R9Iv4+D0yFQw9xiP8pUA+H58DFwHJdkWEAKs4LNn wv1eJfK44XyNQHkz1VAcFKr+xJ/z4ci+guhUy5piqXW2PNw6OPhRxO0phbr4fazA6Yzly3Iqw sDIEs5MEVJXNPwVGRO3CmqccNGyJMrJ4YyHb24n480DpjG8R64QmrZ7Ss6/WvDlZam2BNcyOi ruZ5EPAnuDErJBl7YTQolaUhTZcNnLlXX7QHXpvreoH/Iax5Cl4Smh6D8dFKZ5KBDhC3ck7tr ZQM8fdDfvK3cdYsOOm/YMtVcH+WZsDulIh40fQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc-8 reports missing error handling in blinkm_detect, when blinkm() fails, tmpargs[] is uninitialized: drivers/leds/leds-blinkm.c: In function 'blinkm_detect': drivers/leds/leds-blinkm.c:555:6: error: 'tmpargs' may be used uninitialized in this function [-Werror=maybe-uninitialized] This adds a missing error checks. Signed-off-by: Arnd Bergmann --- drivers/leds/leds-blinkm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c index d03ed6b4176b..851c1920b63c 100644 --- a/drivers/leds/leds-blinkm.c +++ b/drivers/leds/leds-blinkm.c @@ -549,8 +549,12 @@ static int blinkm_detect(struct i2c_client *client, struct i2c_board_info *info) /* make sure the blinkM is balanced (read/writes) */ while (count > 0) { ret = blinkm_write(client, BLM_GET_ADDR, NULL); + if (ret) + return ret; usleep_range(5000, 10000); ret = blinkm_read(client, BLM_GET_ADDR, tmpargs); + if (ret) + return ret; usleep_range(5000, 10000); if (tmpargs[0] == 0x09) count = 0; -- 2.9.0