From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753915AbdLDOwI (ORCPT ); Mon, 4 Dec 2017 09:52:08 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:49548 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466AbdLDOwH (ORCPT ); Mon, 4 Dec 2017 09:52:07 -0500 Date: Mon, 4 Dec 2017 15:51:58 +0100 From: Peter Zijlstra To: Song Liu Cc: rostedt@goodmis.org, mingo@redhat.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, daniel@iogearbox.net, kernel-team@fb.com Subject: Re: [PATCH v3 3/6] perf: implement pmu perf_kprobe Message-ID: <20171204145158.dgay4w6dqjrrzdu6@hirez.programming.kicks-ass.net> References: <20171130235023.1414663-1-songliubraving@fb.com> <20171130235023.1414663-6-songliubraving@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171130235023.1414663-6-songliubraving@fb.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 30, 2017 at 03:50:20PM -0800, Song Liu wrote: > diff --git a/kernel/events/core.c b/kernel/events/core.c > index 494eca1..49bbf46 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > static inline void perf_tp_register(void) > { > perf_pmu_register(&perf_tracepoint, "tracepoint", PERF_TYPE_TRACEPOINT); > + perf_pmu_register(&perf_kprobe, "kprobe", -1); Should we maybe not register this PMU when !KPROBE_EVENTS ? That looks to save a bunch of #ifdeffery later on. > }