From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752260AbdLDR3p (ORCPT ); Mon, 4 Dec 2017 12:29:45 -0500 Received: from mga06.intel.com ([134.134.136.31]:52000 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751421AbdLDR3l (ORCPT ); Mon, 4 Dec 2017 12:29:41 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,359,1508828400"; d="scan'208";a="8936458" Date: Mon, 4 Dec 2017 19:23:04 +0200 From: Mika Westerberg To: Colin King Cc: Heikki Krogerus , Linus Walleij , linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] pinctrl: intel: ensure error return ret is initialized Message-ID: <20171204172304.GE22431@lahna.fi.intel.com> References: <20171204170815.14779-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171204170815.14779-1-colin.king@canonical.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 04, 2017 at 05:08:15PM +0000, Colin King wrote: > From: Colin Ian King > > In the (unlikely) event that community->ngpps is zero, or if every > gpp->gpio_base is less than zero, then an ininitialized value in > ret is returned by function intel_gpio_add_pin_ranges. Fix this by > ensuring ret is initialized to zero. It's a moot point, but I think > it is worthwhile ensuring this corner case is fixed. I agree. > Detected by CoverityScan, CID#1462415 ("Uninitialized scalar variable") > > Fixes: a60eac3239f0 ("pinctrl: intel: Allow custom GPIO base for pad groups") > Signed-off-by: Colin Ian King Acked-by: Mika Westerberg