From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Subject: [PATCH net-next 1/5] net: dsa: mv88e6xxx: egress floods all DSA ports
Date: Mon, 4 Dec 2017 12:34:53 -0500 [thread overview]
Message-ID: <20171204173457.14873-2-vivien.didelot@savoirfairelinux.com> (raw)
In-Reply-To: <20171204173457.14873-1-vivien.didelot@savoirfairelinux.com>
The mv88e6xxx driver currently assumes a single CPU port in the fabric
and thus floods frames with unknown DA on a single DSA port, the one
that is one hop closer to the CPU port.
With multiple CPU ports in mind, this isn't true anymore because CPU
ports could be found behind both DSA ports of a device in-between
others.
For example in a A <-> B <-> C fabric, both A and C having CPU ports,
device B will have to flood such frame to its two DSA ports.
This patch considers both CPU and DSA ports of a device as upstream
ports, where to flood frames with unknown DA addresses.
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
drivers/net/dsa/mv88e6xxx/chip.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index b5e0987c88f0..15475dbb738b 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -1723,7 +1723,8 @@ static int mv88e6xxx_setup_message_port(struct mv88e6xxx_chip *chip, int port)
static int mv88e6xxx_setup_egress_floods(struct mv88e6xxx_chip *chip, int port)
{
- bool flood = port == dsa_upstream_port(chip->ds);
+ struct dsa_switch *ds = chip->ds;
+ bool flood = dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port);
/* Upstream ports flood frames with unknown unicast or multicast DA */
if (chip->info->ops->port_set_egress_floods)
--
2.15.1
next prev parent reply other threads:[~2017-12-04 17:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 17:34 [PATCH net-next 0/5] net: dsa: use per-port upstream port Vivien Didelot
2017-12-04 17:34 ` Vivien Didelot [this message]
2017-12-04 17:34 ` [PATCH net-next 2/5] net: dsa: mv88e6xxx: helper to setup " Vivien Didelot
2017-12-04 17:34 ` [PATCH net-next 3/5] net: dsa: mv88e6xxx: setup global " Vivien Didelot
2017-12-04 17:34 ` [PATCH net-next 4/5] net: dsa: assign a CPU port to DSA port Vivien Didelot
2017-12-04 17:34 ` [PATCH net-next 5/5] net: dsa: return per-port upstream port Vivien Didelot
2017-12-05 19:47 ` [PATCH net-next 0/5] net: dsa: use " David Miller
2017-12-05 19:57 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204173457.14873-2-vivien.didelot@savoirfairelinux.com \
--to=vivien.didelot@savoirfairelinux.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®