From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752891AbdLDV2e (ORCPT ); Mon, 4 Dec 2017 16:28:34 -0500 Received: from mail-oi0-f65.google.com ([209.85.218.65]:37750 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752674AbdLDV2b (ORCPT ); Mon, 4 Dec 2017 16:28:31 -0500 X-Google-Smtp-Source: AGs4zMZHmMmhpcFqQOFxwR/ZCczRGhnfGno2M1GbWzYGsJKgeJ+fFrtAkkb/HDuFIPMPrQa1KAT1lA== Date: Mon, 4 Dec 2017 15:28:29 -0600 From: Rob Herring To: srinivas.kandagatla@linaro.org Cc: gregkh@linuxfoundation.org, broonie@kernel.org, alsa-devel@alsa-project.org, sdharia@codeaurora.org, bp@suse.de, poeschel@lemonage.de, treding@nvidia.com, andreas.noever@gmail.com, alan@linux.intel.com, mathieu.poirier@linaro.org, daniel@ffwll.ch, jkosina@suse.cz, sharon.dvir1@mail.huji.ac.il, joe@perches.com, davem@davemloft.net, james.hogan@imgtec.com, michael.opdenacker@free-electrons.com, pawel.moll@arm.com, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, vinod.koul@intel.com, arnd@arndb.de Subject: Re: [PATCH v8 10/13] dt-bindings: Add qcom slimbus controller bindings Message-ID: <20171204212829.bmcp5dktc5w46rom@rob-hp-laptop> References: <20171130174200.6684-1-srinivas.kandagatla@linaro.org> <20171130174200.6684-11-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171130174200.6684-11-srinivas.kandagatla@linaro.org> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 30, 2017 at 05:41:57PM +0000, srinivas.kandagatla@linaro.org wrote: > From: Sagar Dharia > > This patch add device tree bindings for Qualcomm slimbus controller. > > Signed-off-by: Sagar Dharia > Signed-off-by: Srinivas Kandagatla > --- > .../devicetree/bindings/slimbus/slim-qcom-ctrl.txt | 39 ++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt > > diff --git a/Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt b/Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt > new file mode 100644 > index 000000000000..93a6fdaf09b3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt > @@ -0,0 +1,39 @@ > +Qualcomm SLIMbus controller > +This controller is used if applications processor driver controls SLIMbus > +master component. > + > +Required properties: > + > + - #address-cells - refer to Documentation/devicetree/bindings/slimbus/bus.txt > + - #size-cells - refer to Documentation/devicetree/bindings/slimbus/bus.txt > + > + - reg : Offset and length of the register region(s) for the device > + - reg-names : Register region name(s) referenced in reg above > + Required register resource entries are: > + "ctrl": Physical address of controller register blocks > + "slew": required for "qcom,apq8064-slim" SOC. > + - compatible : should be "qcom,-slim" for SOC specific compatible > + followed by "qcom,slim" for fallback. > + - interrupts : Interrupt number used by this controller > + - clocks : Interface and core clocks used by this SLIMbus controller > + - clock-names : Required clock-name entries are: > + "iface_clk" : Interface clock for this controller > + "core_clk" : Interrupt for controller core's BAM Doesn't match the example. You should drop the '_clk'. With that, Reviewed-by: Rob Herring > + > +Example: > + > + slim@28080000 { > + compatible = "qcom,apq8064-slim", "qcom,slim"; > + reg = <0x28080000 0x2000>, <0x80207C 4>; > + reg-names = "ctrl", "slew"; > + interrupts = <0 33 0>; > + clocks = <&lcc SLIMBUS_SRC>, <&lcc AUDIO_SLIMBUS_CLK>; > + clock-names = "iface", "core"; > + #address-cells = <2>; > + #size-cell = <0>; > + > + wcd9310: audio-codec@1,0{ > + compatible = "slim217,60"; > + reg = <1 0>; > + }; > + }; > -- > 2.15.0 >