mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: zumeng.chen@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	claudiu.manoil@nxp.com
Subject: Re: [PATCH 1/1] gianfar: fix a flooded alignment reports because of padding issue.
Date: Tue, 05 Dec 2017 11:48:46 -0500 (EST)	[thread overview]
Message-ID: <20171205.114846.832978941751793517.davem@davemloft.net> (raw)
In-Reply-To: <1512357722-12124-1-git-send-email-zumeng.chen@gmail.com>

From: Zumeng Chen <zumeng.chen@gmail.com>
Date: Mon, 4 Dec 2017 11:22:02 +0800

> According to LS1021A RM, the value of PAL can be set so that the start of the
> IP header in the receive data buffer is aligned to a 32-bit boundary. Normally,
> setting PAL = 2 provides minimal padding to ensure such alignment of the IP
> header.
> 
> However every incoming packet's 8-byte time stamp will be inserted into the
> packet data buffer as padding alignment bytes when hardware time stamping is
> enabled.
> 
> So we set the padding 8+2 here to avoid the flooded alignment faults:
> 
> root@128:~# cat /proc/cpu/alignment
> User:           0
> System:         17539 (inet_gro_receive+0x114/0x2c0)
> Skipped:        0
> Half:           0
> Word:           0
> DWord:          0
> Multi:          17539
> User faults:    2 (fixup)
> 
> Also shown when exception report enablement
 ...
> Signed-off-by: Zumeng Chen <zumeng.chen@gmail.com>

Applied.

      parent reply	other threads:[~2017-12-05 16:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-04  3:22 Zumeng Chen
2017-12-04 16:06 ` Claudiu Manoil
2017-12-05  0:24   ` Zumeng Chen
2017-12-05  2:18   ` Zumeng Chen
2017-12-05 16:48 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171205.114846.832978941751793517.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=claudiu.manoil@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=zumeng.chen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®