From: Bjorn Helgaas <helgaas@kernel.org>
To: unlisted-recipients:; (no To-header on input)
Cc: Jason Cooper <jason@lakedaemon.net>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Thomas Gleixner <tglx@linutronix.de>,
Yinghai Lu <yinghai@kernel.org>, Matt Turner <mattst88@gmail.com>,
Richard Henderson <rth@twiddle.net>
Subject: [PATCH v1 4/6] irqchip/i8259: Set I/O port resource types correctly
Date: Mon, 04 Dec 2017 18:40:36 -0600 [thread overview]
Message-ID: <20171205004036.12535.80656.stgit@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20171205003525.12535.89924.stgit@bhelgaas-glaptop.roam.corp.google.com>
From: Bjorn Helgaas <bhelgaas@google.com>
Set I/O port resource structs to have IORESOURCE_IO in their type field.
Previously we marked these as merely IORESOURCE_BUSY without indicating the
type. Setting the type doesn't fix any functional problem but makes %pR
on the resource work better.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/irqchip/irq-i8259.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-i8259.c b/drivers/irqchip/irq-i8259.c
index 7aafbb091b67..b0d4aab1a58c 100644
--- a/drivers/irqchip/irq-i8259.c
+++ b/drivers/irqchip/irq-i8259.c
@@ -289,14 +289,14 @@ static struct resource pic1_io_resource = {
.name = "pic1",
.start = PIC_MASTER_CMD,
.end = PIC_MASTER_IMR,
- .flags = IORESOURCE_BUSY
+ .flags = IORESOURCE_IO | IORESOURCE_BUSY
};
static struct resource pic2_io_resource = {
.name = "pic2",
.start = PIC_SLAVE_CMD,
.end = PIC_SLAVE_IMR,
- .flags = IORESOURCE_BUSY
+ .flags = IORESOURCE_IO | IORESOURCE_BUSY
};
static int i8259A_irq_domain_map(struct irq_domain *d, unsigned int virq,
next prev parent reply other threads:[~2017-12-05 0:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 0:39 [PATCH v1 0/6] resource: Set struct " Bjorn Helgaas
2017-12-05 0:40 ` [PATCH v1 1/6] vgacon: Set VGA struct resource types Bjorn Helgaas
2018-01-03 15:10 ` Bartlomiej Zolnierkiewicz
2017-12-05 0:40 ` [PATCH v1 2/6] MIPS: Set I/O port resource types correctly Bjorn Helgaas
2017-12-05 0:40 ` [PATCH v1 3/6] powerpc: " Bjorn Helgaas
2017-12-05 0:40 ` Bjorn Helgaas [this message]
2017-12-05 0:40 ` [PATCH v1 5/6] resource: Set type of "reserve=" user-specified resources Bjorn Helgaas
2017-12-05 0:40 ` [PATCH v1 6/6] resource: Set type when reserving new regions Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205004036.12535.80656.stgit@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=benh@kernel.crashing.org \
--cc=ink@jurassic.park.msu.ru \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mattst88@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®