From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752659AbdLEIbz (ORCPT ); Tue, 5 Dec 2017 03:31:55 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:46756 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752540AbdLEIbv (ORCPT ); Tue, 5 Dec 2017 03:31:51 -0500 X-Google-Smtp-Source: AGs4zMbTeGfvCvy0RrWQCxU+SRKkKP9B2ru0FP4cO/bwWTGwFIQ3Gzq6ctu/7WFhycFS3kh412LrOw== Date: Tue, 5 Dec 2017 08:31:48 +0000 From: Lee Jones To: Colin King Cc: Rui Feng , Daniel Bristot de Oliveira , Ulf Hansson , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] misc: rtsx: make several functions static Message-ID: <20171205083148.gtfc2ayn5kmmyok7@dell> References: <20171204124329.5569-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171204124329.5569-1-colin.king@canonical.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 04 Dec 2017, Colin King wrote: > From: Colin Ian King > > Several functions are local to the source and do not need to be in global > scope, so make them static. > > Cleans up sparse warnings: > symbol 'rtsx_pm_power_saving' was not declared. Should it be static? > symbol 'rtsx_set_l1off_sub_cfg_d0' was not declared. Should it be static? > symbol 'rtsx_pm_full_on' was not declared. Should it be static? > symbol 'rtsx_comm_set_ltr_latency' was not declared. Should it be static? > symbol 'rtsx_pci_process_ocp' was not declared. Should it be static? > symbol 'rtsx_pci_process_ocp_interrupt' was not declared. Should it be > static? > > Signed-off-by: Colin Ian King > --- > drivers/misc/cardreader/rtsx_pcr.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog