From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753354AbdLEKgo (ORCPT ); Tue, 5 Dec 2017 05:36:44 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:48401 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752974AbdLEKgm (ORCPT ); Tue, 5 Dec 2017 05:36:42 -0500 Date: Tue, 5 Dec 2017 11:36:18 +0100 From: Maxime Ripard To: Jernej Skrabec Cc: wens@csie.org, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, icenowy@aosc.io, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 00/27] Improve DE2 support Message-ID: <20171205103618.ps64m57xemsbo44r@flea.lan> References: <20171201060550.10392-1-jernej.skrabec@siol.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hztx7s5a66365ryh" Content-Disposition: inline In-Reply-To: <20171201060550.10392-1-jernej.skrabec@siol.net> User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hztx7s5a66365ryh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Dec 01, 2017 at 07:05:23AM +0100, Jernej Skrabec wrote: > Current DE2 driver is very basic and uses a lot of magic constants since > there is no documentation and knowledge about it was limited at the time. >=20 > With studying BSP source code, deeper knowledge was gained which allows > to improve mainline driver considerably. >=20 > At the beginning of this series, some code refactoring is done as well > as adding some checks (patches 1-15). >=20 > Further patches add multi-plane support with HW scaling and all possible > RGB formats (patches 16-21). >=20 > At last, support for YUV formats is added (patches 22-26). >=20 > At the end, I included patch which puts lowest plane before second lowest. > This should help testing VI planes when mixer has configuration 1 VI plane > and 1 or more UI planes (most SoCs except V3s). >=20 > This code was developed on H3, but it should work on every SoC if correct > configuration structure is provided. >=20 > H3 code can be found here: > https://github.com/jernejsk/linux-1/commits/de2_impr_for_next Thanks a lot for that huge rework. I've applied the patches 1 to 26, and will push them to drm-misc once the compilations are done. In the future, if you happen to do such a huge rework again (which hopefully won't be needed :)), please use the -M option of format-patch. It will reduce a lot the verbosity of files renaming and will help the review. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --hztx7s5a66365ryh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlomdp4ACgkQ0rTAlCFN r3RsFA/+LRjImAMGajqAXdUsApF5kP1RAD/77XL2Io6K7hJ5X/moihtckovfS89I YHyjL72krHBHfaHZKCwTZ9wXvfF2kinmeJfwTge8Dz9R7o8QUgQgzQS8Ur3VIDxM QoaJaFTTIFMtjsDOb+v1OE2/IwZ5g9U2yTPDmcMpltcJdgr3ltHNs7L0MMcjeDmK xodIvytOcJv5lKzcXkdRV3zIGgc61JFy8RkGhYD9VmI81HZB70TMRVlEMSk01SYB fLNbAqS+EVfcCmw896wqcLw0J5nwBHcgLQJ5Phq1Ynm0K0ZmMgUqkSHfia9DgiSF 69ZP69N/3wdp5+khImEd3rrdvYzJTHjcdIcGvcqR1ddCBnMOKBfJ47Fxet/IKY0C E3Cd2qsDOA5vulvfo8CqgGBWgYc9eEoJ/J3Ct9oQe8xzWUhPug4gOYI318mFpjbS Jfi+JWRbJmFYGGeNWgiJ2nQ2uWD+f77gmRou7ub1hKgAvKS1kUqIT23wrrP0Gcfz FQWPJeI9tyEbH0jymsOqZ0N4vcqFjN1Pl3uvF081fbHO1lsvTpAxWI07/XvFdg/Y EjLCwtAjwfERngNGx005sYfJlHcvO1wvQNmBCzJSfLg8sxD+IJWjzfkLHfoY5KDj OHZxDhjHzX1F7g62PfSEC8UhJcIf3LCu2ahITYPoEi/d9Dj3rsY= =mL6m -----END PGP SIGNATURE----- --hztx7s5a66365ryh--