From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752649AbdLEPWG (ORCPT ); Tue, 5 Dec 2017 10:22:06 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:61164 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbdLEPWF (ORCPT ); Tue, 5 Dec 2017 10:22:05 -0500 From: Arnd Bergmann To: Mark Fasheh , Joel Becker Cc: Kees Cook , Arnd Bergmann , Andrew Morton , Ingo Molnar , Peter Zijlstra , Joseph Qi , piaojun , ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org Subject: [PATCH] ocfs2: use get_task_comm Date: Tue, 5 Dec 2017 16:20:50 +0100 Message-Id: <20171205152110.2050975-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:7C+UV30zD7NDw68LrXhUcWfQ+oduU2sQQkmcpASnsOS6wmpgU8H wU2E2ESVw1Y9Mt74SAbWjSegL2m82uJWS8Xhx7Y2qvKMkn0RrcWpWIQZDeA3txRlUbFTsSB JmkK3ivhVDl1CrHDddDt529Crnh1Y0w7QOIoDATxEqhNTyo9A4e820M0cttAy+LiDlbI3QT dxHyyOma4ntgk5JqqXIjA== X-UI-Out-Filterresults: notjunk:1;V01:K0:uVxfFG9f5YM=:Gh5weQaiZiwpouWaXUf1TX s0fmiSeCUZDNDV6DnNdG6gmoqkiaqwlXDX+fGx3zaMLCDD0icdaTR7Etrb3yTKYGYpkka3O/A 5orrKw/gqVvA+3Lt6YjlNoYeyJ+Gm+oOzRaGdkHsaJryDSDuKzHM9f+OCKdNfCmDm8xGphJwP Ty+iE9B3wcIEBydQBTQEdZn0d26rBIkc/ZV7UOY8Ye/G2yB3QlBoGmkFHgTuakP5sHIZVOkIt PrJsDm9K7B6r6I4oW21XctFI5ZeANOBZM8lFcEC/3OXQPnoXr2/Dm4aEJG53njdJEA/MAXS/c i5zWPFmpYmxRXZjNOhE3vyCgRyHOFNM09JZngW9cv+u8v4wSO7Ju5Ey/3IRgd/1OiPbn5LWCf UJSedpS51NsjQPA13pKomjJIpBxx57ag4WmAJEhTbzS5+qZjqyh6w6pBgzemXfzZ17xLdY7El WlqsQ1UDdFCM7hO3UlfMD24Gm7WTVK2n/c8wbUJWI8g/SlOnxlhcBRZw6Bn5KFC6TGyzXErkx xuRXu89fNPUJX0TdAdViPNRsE/N2baQkj77sBdWYF6hcOuUwXtrUtotUyJ0n6GzDXUyQVA7U5 0AzMZsaKWSMjK86jVeK7OVuqTgn/HU6E0huOZ9yHIeYynVDNIi2a/MAJE75afZD0a0QrxQOfb eDPMkC6QBQLE7PP7jlSOyuoDdYExNQFkZ7mKmzSAw8kzIv3/LekM/mX+zkbtoVFGp4ADSLRf2 +Iud/3N1N9ROFuUUm/n69Rt2gz5Swmof4hjZwA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While reviewing all callers of get_task_comm(), I stumbled over this one that claimed it was not exported, when in fact it is. Accessing task->comm directly is not safe, so better convert this one to using get_task_comm as well. Signed-off-by: Arnd Bergmann --- fs/ocfs2/cluster/netdebug.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/cluster/netdebug.c b/fs/ocfs2/cluster/netdebug.c index 74a21f6695c8..a51d001b89b1 100644 --- a/fs/ocfs2/cluster/netdebug.c +++ b/fs/ocfs2/cluster/netdebug.c @@ -130,6 +130,7 @@ static void *nst_seq_next(struct seq_file *seq, void *v, loff_t *pos) static int nst_seq_show(struct seq_file *seq, void *v) { struct o2net_send_tracking *nst, *dummy_nst = seq->private; + char comm[TASK_COMM_LEN]; ktime_t now; s64 sock, send, status; @@ -142,8 +143,8 @@ static int nst_seq_show(struct seq_file *seq, void *v) sock = ktime_to_us(ktime_sub(now, nst->st_sock_time)); send = ktime_to_us(ktime_sub(now, nst->st_send_time)); status = ktime_to_us(ktime_sub(now, nst->st_status_time)); + get_task_comm(comm, nst->st_task); - /* get_task_comm isn't exported. oh well. */ seq_printf(seq, "%p:\n" " pid: %lu\n" " tgid: %lu\n" @@ -158,7 +159,7 @@ static int nst_seq_show(struct seq_file *seq, void *v) " wait start: %lld usecs ago\n", nst, (unsigned long)task_pid_nr(nst->st_task), (unsigned long)nst->st_task->tgid, - nst->st_task->comm, nst->st_node, + comm, nst->st_node, nst->st_sc, nst->st_id, nst->st_msg_type, nst->st_msg_key, (long long)sock, -- 2.9.0