From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751989AbdLETX6 (ORCPT ); Tue, 5 Dec 2017 14:23:58 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:34635 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751815AbdLETX5 (ORCPT ); Tue, 5 Dec 2017 14:23:57 -0500 Date: Tue, 5 Dec 2017 20:23:45 +0100 From: Maxime Ripard To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: wens@csie.org, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, icenowy@aosc.io, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 00/27] Improve DE2 support Message-ID: <20171205192345.vjkyunobrbzjjiv3@flea.lan> References: <20171201060550.10392-1-jernej.skrabec@siol.net> <20171205103618.ps64m57xemsbo44r@flea.lan> <23633465.uxSxGdCvtg@jernej-laptop> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yomzhvu42a55zyv7" Content-Disposition: inline In-Reply-To: <23633465.uxSxGdCvtg@jernej-laptop> User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yomzhvu42a55zyv7 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Dec 05, 2017 at 04:52:57PM +0100, Jernej =C5=A0krabec wrote: > Dne torek, 05. december 2017 ob 11:36:18 CET je Maxime Ripard napisal(a): > > Hi, > >=20 > > On Fri, Dec 01, 2017 at 07:05:23AM +0100, Jernej Skrabec wrote: > > > Current DE2 driver is very basic and uses a lot of magic constants si= nce > > > there is no documentation and knowledge about it was limited at the t= ime. > > >=20 > > > With studying BSP source code, deeper knowledge was gained which allo= ws > > > to improve mainline driver considerably. > > >=20 > > > At the beginning of this series, some code refactoring is done as well > > > as adding some checks (patches 1-15). > > >=20 > > > Further patches add multi-plane support with HW scaling and all possi= ble > > > RGB formats (patches 16-21). > > >=20 > > > At last, support for YUV formats is added (patches 22-26). > > >=20 > > > At the end, I included patch which puts lowest plane before second lo= west. > > > This should help testing VI planes when mixer has configuration 1 VI = plane > > > and 1 or more UI planes (most SoCs except V3s). > > >=20 > > > This code was developed on H3, but it should work on every SoC if cor= rect > > > configuration structure is provided. > > >=20 > > > H3 code can be found here: > > > https://github.com/jernejsk/linux-1/commits/de2_impr_for_next > >=20 > > Thanks a lot for that huge rework. > >=20 > > I've applied the patches 1 to 26, and will push them to drm-misc once > > the compilations are done. > >=20 > > In the future, if you happen to do such a huge rework again (which > > hopefully won't be needed :)), please use the -M option of > > format-patch. It will reduce a lot the verbosity of files renaming and > > will help the review. >=20 > Noted. It turned out that there was also a change queued for drm-misc that was renaming (and changing the prototype of) drm_plane_helper_check_state into drm_atomic_helper_check_plane_state. I fixed that up in tree, and tested on the A83t, but you probably want to double check. > I think I missed initialization of min_scaler and max_scaler in=20 > sun8i_vi_layer_atomic_check() in sun8i_vi_layer.c when I was reworking=20 > patches. >=20 > Will you fix patch with those two lines > min_scale =3D DRM_PLANE_HELPER_NO_SCALING; > max_scale =3D DRM_PLANE_HELPER_NO_SCALING; >=20 > or should I send new patch which fixes that or should I send new version = of=20 > original patch? We don't rebase in drm-misc, so please send an additional patch. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --yomzhvu42a55zyv7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlom8hoACgkQ0rTAlCFN r3TC3g/8D7uxDAYrruTt9aILZNcnF14zwlHowSuhzrJ6kFdiFAeT/VLChJVloTN4 mKqEapF16CL4aQnNM1TM9OYIdd4wPVCjx+DSnpRn/VUsJxxmTEe/UMiJJqpwTSuh dXwZJ8VMH5faF7DhD46G9aeHTTwd+tpRu/TDscZV0rIgGXQz7773Sph3ZSrscqI3 27QszejEvNMFbG+3r6CIFOm8pHH01a4QJyiVPwcBsHQFlPCPVHVKwVGihUjq+Nze w5dOjNxBGdT3A5DFQZfawuzNKyeFETx5eyRLGTzY2Adbk0jT8ZSG4CiiXMLfA3lG yRtqLNcP5UkRI6XPiW4B1jdWwituko+4aZdKh9gHsz2XHAkEhibrGxWtrT8Whtjv fzAAUQV1YGKlU4nL+aUIyz3tZBC+gwXlTg6D+2+BzSl+6KXSz/YzbHXrfyZdjQGk cTXTuY2cdwCsWaPD1sk7YvR0rVwTGmfIynUm1DvO2Wfu2HW9YQ65XzdLwDZxM4d4 vbvo0UBSH42bDeHDUi3Db4YvVSjCdZTwgdWRQj4w90edDpnFbpd1j2gVgw2J8hEM uAp/ZqF1d+38jkJF4IrYQTkNhFbulsKO2alApJMfCX6zlx9zHRGnv0r1Wj2fmaYD PwX3IAANmKtadzCayDxmsBZY7qtnJHRI1WWR7Zyiu4dEC32zRgw= =iasR -----END PGP SIGNATURE----- --yomzhvu42a55zyv7--