From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751014AbdLGJOp convert rfc822-to-8bit (ORCPT ); Thu, 7 Dec 2017 04:14:45 -0500 Received: from mx2.suse.de ([195.135.220.15]:39094 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbdLGJOo (ORCPT ); Thu, 7 Dec 2017 04:14:44 -0500 Date: Thu, 7 Dec 2017 10:14:42 +0100 From: Thomas Bogendoerfer To: Michael Chan Cc: Netdev , open list Subject: Re: [PATCH net-next] bnxt: Don't print message, if DAC isn't connected on both ends Message-Id: <20171207101442.a5b7446d3aefe429d60f54cb@suse.de> In-Reply-To: References: <20171205123340.3307-1-tbogendoerfer@suse.de> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 Dec 2017 11:27:31 -0800 Michael Chan wrote: > On Tue, Dec 5, 2017 at 4:33 AM, Thomas Bogendoerfer > wrote: > > bnxt driver spams logfiles with > > > > [ 541.003065] bnxt_en 0000:5d:00.1 eth5: Link speed -1 no longer supported > > > > if a direct attached cable (DAC) is plugged into the bnxt card and is > > unplugged on the other side. This patch removes the code printing this > > message, since it doesn't provide any useful information. > > > > Signed-off-by: Thomas Bogendoerfer > > --- > > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 --------- > > 1 file changed, 9 deletions(-) > > > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c > > index 8c1dd60eab6f..8a2319ed79dc 100644 > > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c > > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c > > @@ -1701,18 +1701,9 @@ static int bnxt_async_event_process(struct bnxt *bp, > > /* TODO CHIMP_FW: Define event id's for link change, error etc */ > > switch (event_id) { > > case ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE: { > > - u32 data1 = le32_to_cpu(cmpl->event_data1); > > - struct bnxt_link_info *link_info = &bp->link_info; > > - > > if (BNXT_VF(bp)) > > goto async_event_process_exit; > > - if (data1 & 0x20000) { > > - u16 fw_speed = link_info->force_link_speed; > > - u32 speed = bnxt_fw_to_ethtool_speed(fw_speed); > > > > - netdev_warn(bp->dev, "Link speed %d no longer supported\n", > > - speed); > > - } > > This is supposed to provide useful information to the user under some > conditions. well, it will print the forced rate, if there is one configured and -1 otherwise, if the link is lost or will not come up because of a cable problem. I don't see much value in that... Thomas. -- SUSE Linux GmbH GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)