From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752070AbdLGJjH convert rfc822-to-8bit (ORCPT ); Thu, 7 Dec 2017 04:39:07 -0500 Received: from mx2.suse.de ([195.135.220.15]:40693 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbdLGJjG (ORCPT ); Thu, 7 Dec 2017 04:39:06 -0500 Date: Thu, 7 Dec 2017 10:39:04 +0100 From: Thomas Bogendoerfer To: Michael Chan Cc: Netdev , open list Subject: Re: [PATCH net-next] bnxt: Don't print message, if DAC isn't connected on both ends Message-Id: <20171207103904.8eda285995f3dc159cb62127@suse.de> In-Reply-To: References: <20171205123340.3307-1-tbogendoerfer@suse.de> <20171207101442.a5b7446d3aefe429d60f54cb@suse.de> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 7 Dec 2017 01:24:43 -0800 Michael Chan wrote: > On Thu, Dec 7, 2017 at 1:14 AM, Thomas Bogendoerfer > wrote: > > well, it will print the forced rate, if there is one configured and -1 otherwise, > > if the link is lost or will not come up because of a cable problem. I don't see much > > value in that... > > > The main purpose is to tell the user that the speed he selected for a > port is no longer supported due to an incompatible speed configured on > the other port. This is useful for the user so that he can either > take action to change the speed or do nothing as he sees fit. just out of curiosity what's meant my imcompatible speed on the other port ? Does the message show up continously like in the problem case I already know ? Thomas. -- SUSE Linux GmbH GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)