From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Roman Gushchin <guro@fb.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-team@fb.com>, <ast@kernel.org>, <daniel@iogearbox.net>,
<kafai@fb.com>, Quentin Monnet <quentin.monnet@netronome.com>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH v2 net-next 3/4] bpftool: implement prog load command
Date: Thu, 7 Dec 2017 13:55:25 -0800 [thread overview]
Message-ID: <20171207135525.4ce09b48@cakuba.netronome.com> (raw)
In-Reply-To: <20171207183909.16240-4-guro@fb.com>
On Thu, 7 Dec 2017 18:39:08 +0000, Roman Gushchin wrote:
> Add the prog load command to load a bpf program from a specified
> binary file and pin it to bpffs.
>
> Usage description and examples are given in the corresponding man
> page.
>
> Syntax:
> $ bpftool prog load SOURCE_FILE FILE
>
> FILE is a non-existing file on bpffs.
>
> Signed-off-by: Roman Gushchin <guro@fb.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
The only reservation I have is that SRC may confuse people, would it
make sense to call the compiled code OBJ? I'm afraid someone may try
to load a C source...
next prev parent reply other threads:[~2017-12-07 21:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 18:39 [PATCH v2 net-next 0/4] bpftool: cgroup bpf operations Roman Gushchin
2017-12-07 18:39 ` [PATCH v2 net-next 1/4] libbpf: add ability to guess program type based on section name Roman Gushchin
2017-12-08 10:33 ` Quentin Monnet
2017-12-07 18:39 ` [PATCH v2 net-next 2/4] libbpf: prefer global symbols as bpf program name source Roman Gushchin
2017-12-07 18:39 ` [PATCH v2 net-next 3/4] bpftool: implement prog load command Roman Gushchin
2017-12-07 21:55 ` Jakub Kicinski [this message]
2017-12-08 10:33 ` Quentin Monnet
2017-12-07 18:39 ` [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations Roman Gushchin
2017-12-07 19:22 ` David Ahern
2017-12-07 22:23 ` Jakub Kicinski
2017-12-07 23:00 ` Philippe Ombredanne
2017-12-08 14:17 ` Roman Gushchin
2017-12-08 10:34 ` Quentin Monnet
2017-12-08 13:56 ` Philippe Ombredanne
2017-12-08 14:53 ` Roman Gushchin
2017-12-08 14:12 ` Roman Gushchin
2017-12-08 15:39 ` Quentin Monnet
2017-12-08 16:52 ` David Ahern
2017-12-08 23:30 ` Jakub Kicinski
2017-12-09 19:19 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207135525.4ce09b48@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=guro@fb.com \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quentin.monnet@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome