From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753205AbdLGQZm (ORCPT ); Thu, 7 Dec 2017 11:25:42 -0500 Received: from mx2.suse.de ([195.135.220.15]:53849 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752387AbdLGQZ1 (ORCPT ); Thu, 7 Dec 2017 11:25:27 -0500 Date: Thu, 7 Dec 2017 17:25:25 +0100 From: Michal Hocko To: Suren Baghdasaryan Cc: Sergey Senozhatsky , Andrew Morton , Johannes Weiner , hillf.zj@alibaba-inc.com, minchan@kernel.org, mgorman@techsingularity.net, ying.huang@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tim Murray , Todd Kjos Subject: Re: [PATCH] mm: terminate shrink_slab loop if signal is pending Message-ID: <20171207162525.GL20234@dhcp22.suse.cz> References: <20171206192026.25133-1-surenb@google.com> <20171207095223.GB574@jagdpanzerIV> <20171207095835.GE20234@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 07-12-17 07:46:07, Suren Baghdasaryan wrote: > I'm, terribly sorry. My original code was checking for additional > condition which I realized is not useful here because it would mean > the signal was already processed. Should have missed the error while > removing it. Will address Michal's comments and fix the problem. yes, rebasing at last moment tend to screw things... No worries, I would be more worried about the general approach here and its documentataion. -- Michal Hocko SUSE Labs