From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754125AbdLHPow (ORCPT ); Fri, 8 Dec 2017 10:44:52 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:54858 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753802AbdLHPov (ORCPT ); Fri, 8 Dec 2017 10:44:51 -0500 Date: Fri, 08 Dec 2017 10:44:49 -0500 (EST) Message-Id: <20171208.104449.1637984942527300904.davem@davemloft.net> To: mst@redhat.com Cc: jasowang@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, eric.dumazet@gmail.com, willemb@google.com Subject: Re: [PATCH net-next V2] tuntap: fix possible deadlock when fail to register netdev From: David Miller In-Reply-To: <20171208064232-mutt-send-email-mst@kernel.org> References: <1512705750-14799-1-git-send-email-jasowang@redhat.com> <20171208064232-mutt-send-email-mst@kernel.org> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 08 Dec 2017 07:44:50 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Michael S. Tsirkin" Date: Fri, 8 Dec 2017 06:43:44 +0200 > On Fri, Dec 08, 2017 at 12:02:30PM +0800, Jason Wang wrote: >> Private destructor could be called when register_netdev() fail with >> rtnl lock held. This will lead deadlock in tun_free_netdev() who tries >> to hold rtnl_lock. Fixing this by switching to use spinlock to >> synchronize. >> >> Fixes: 96f84061620c ("tun: add eBPF based queue selection method") >> Reported-by: Eric Dumazet >> Cc: Eric Dumazet >> Cc: Willem de Bruijn >> Signed-off-by: Jason Wang > > Acked-by: Michael S. Tsirkin Applied, thanks.