From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752734AbdLHGTS (ORCPT ); Fri, 8 Dec 2017 01:19:18 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:45329 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbdLHGTR (ORCPT ); Fri, 8 Dec 2017 01:19:17 -0500 X-Google-Smtp-Source: AGs4zMbS15vyEG/J64Y3lsa7U+lqGH57c9ZM90T/dWvGwuKnNpZe5b01FFIOUWP2FvGhXgzaRb63fw== Date: Fri, 8 Dec 2017 07:19:13 +0100 From: Ingo Molnar To: alexander.levin@verizon.com Cc: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] tools/lib/lockdep: Add missing declaration of 'pr_cont()' Message-ID: <20171208061913.4pvol2tezybgbdzr@gmail.com> References: <20171207161057.7406-1-alexander.levin@verizon.com> <20171207161057.7406-2-alexander.levin@verizon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171207161057.7406-2-alexander.levin@verizon.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * alexander.levin@verizon.com wrote: > From: Mengting Zhang > > An annoying compile warning due to missing declaration is shown below: > In file included from lockdep.c:27:0: > ../../../kernel/locking/lockdep.c: In function 'print_unlock_imbalance_bug' : > ../../../kernel/locking/lockdep.c:3544:2: warning: implicit declaration of function 'pr_cont' [-Wimplicit-function-declaration] > pr_cont(") at:\n"); > ^ All build warnings are annoying, please formulate this in a more neutral fashion. Also, please separate the compiler splat from the changelog text with an empty line, and align it vertically as well so that it seprates more. Please do this for the second patch as well, and try to harmonize the style of the changelogs. This is an example of a clean changelog that fixes a build warning: commit 1b3b5219abfd6a214e99018747e9fe98514b43ca Author: Arnaldo Carvalho de Melo Date: Mon Nov 27 12:18:23 2017 -0300 tools headers: Syncronize mman.h ABI header To add support for the MAP_SYNC flag introduced in: b6fb293f2497 ("mm: Define MAP_SYNC and VM_SYNC flags") Update tools/perf/trace/beauty/mmap.c to support that flag. This silences this perf build warning: Warning: Kernel ABI header at 'tools/include/uapi/asm-generic/mman.h' differs from latest version at 'include/uapi/asm-generic/mman.h' Cc: Adrian Hunter Cc: Dan Williams Cc: David Ahern Cc: Jan Kara Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: https://lkml.kernel.org/n/tip-14zyk3iywrj37c7g1eagmzbo@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo Thanks, Ingo