From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754007AbdLHOEP (ORCPT ); Fri, 8 Dec 2017 09:04:15 -0500 Received: from omzsmtpe03.verizonbusiness.com ([199.249.25.208]:65221 "EHLO omzsmtpe03.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753891AbdLHOEK (ORCPT ); Fri, 8 Dec 2017 09:04:10 -0500 From: alexander.levin@verizon.com X-Host: surveyor.tdc.vzwcorp.com To: Ingo Molnar CC: "linux-kernel@vger.kernel.org" , "Peter Zijlstra" Subject: Re: [PATCH 2/2] tools/lib/lockdep: add empty declaration for early_param Thread-Topic: [PATCH 2/2] tools/lib/lockdep: add empty declaration for early_param Thread-Index: AQHTcC1QIBDrgD8u/0a6+Awhgc5khQ== Date: Fri, 8 Dec 2017 14:03:25 +0000 Message-ID: <20171208140322.cmt3engara5tymq6@sasha-lappy> References: <20171207161057.7406-1-alexander.levin@verizon.com> <20171207161057.7406-3-alexander.levin@verizon.com> <20171208060920.u56ee3kkyyqdmjol@gmail.com> <20171208062010.yrcbazicfut7pmk2@gmail.com> In-Reply-To: <20171208062010.yrcbazicfut7pmk2@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: NeoMutt/20170113 (1.7.2) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] Content-Type: text/plain; charset="utf-8" Content-ID: <761A27F2CE5A9B458110D14EC9EE5F6F@vzwcorp.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vB8E4LvB008966 On Fri, Dec 08, 2017 at 07:20:10AM +0100, Ingo Molnar wrote: > >* Ingo Molnar wrote: > >> >> * alexander.levin@verizon.com wrote: >> >> > Fixes a compilation error: >> > >> > CC lockdep.o >> > In file included from lockdep.c:28:0: >> > ../../../kernel/locking/lockdep.c:89:13: error: expected declaration specifiers or ‘...’ before string constant >> > early_param("crossrelease_fullstack", allow_crossrelease_fullstack); >> > ^~~~~~~~~~~~~~~~~~~~~~~~ >> > ../../../kernel/locking/lockdep.c:89:39: error: expected declaration specifiers or ‘...’ before ‘allow_crossrelease_fullstack’ >> > early_param("crossrelease_fullstack", allow_crossrelease_fullstack); >> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> Ugh, this changelog was in DOS format (had extra \r's) - how did that happen? > >Hm, so it's because the second patch email was sent as as a base64 encoded email: > > Content-Transfer-Encoding: base64 > >totally not recommended and git-send-email will not do that - what happened? I'm not sure, this was sent using git-send-email... >> >> Fixed it up. > >Actually, could you please resend the whole series, with a fix for the other >warning I reported added, with the changelogs fixed, and not MIME encoded? Sure! -- Thanks, Sasha