From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752646AbdLKQTW (ORCPT ); Mon, 11 Dec 2017 11:19:22 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:36234 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752405AbdLKQTT (ORCPT ); Mon, 11 Dec 2017 11:19:19 -0500 Date: Mon, 11 Dec 2017 11:19:17 -0500 (EST) Message-Id: <20171211.111917.1950680033944722044.davem@davemloft.net> To: jbrunet@baylibre.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, khilman@baylibre.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v3] net: phy: meson-gxl: detect LPA corruption From: David Miller In-Reply-To: <20171208110811.30789-1-jbrunet@baylibre.com> References: <20171208110811.30789-1-jbrunet@baylibre.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 11 Dec 2017 08:19:19 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jerome Brunet Date: Fri, 8 Dec 2017 12:08:11 +0100 > I suppose this patch probably seems a bit hacky, especially the part > about the link partner acknowledge. I'm trying to figure out if the > value in MII_LPA makes sense but I don't have such a deep knowledge > of the ethernet spec. Yeah it's not the prettiest thing in the world, but if this is what you need to check to detect this situation then there isn't much else you can do. Applied, thanks.