From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752627AbdLKKsV (ORCPT ); Mon, 11 Dec 2017 05:48:21 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:35444 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbdLKKsU (ORCPT ); Mon, 11 Dec 2017 05:48:20 -0500 X-Google-Smtp-Source: ACJfBosbqSzrUIETRAPjtn8wuSH7I8yJlhYjAj1r9tUvB6E8Orp0bIbFMb8Ukz6TRxMqilAB3bQq2w== From: Bartosz Golaszewski To: Andy Whitcroft , Joe Perches , Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH] checkpatch: don't require octal permissions for "0" in module_param Date: Mon, 11 Dec 2017 11:48:17 +0100 Message-Id: <20171211104817.14321-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.15.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org File permissions set to "0" in the module_param family of macros mean that the parameter should not show up in sysfs. Don't require octal permissions in this case. Signed-off-by: Bartosz Golaszewski --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 040aa79e1d9d..32c37f8bc143 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6303,7 +6303,7 @@ sub process { if ($stat =~ /$test/) { my $val = $1; $val = $6 if ($skip_args ne ""); - if (($val =~ /^$Int$/ && $val !~ /^$Octal$/) || + if (($func =~ /^module_param/ && $val ne "0" && $val =~ /^$Int$/ && $val !~ /^$Octal$/) || ($val =~ /^$Octal$/ && length($val) ne 4)) { ERROR("NON_OCTAL_PERMISSIONS", "Use 4 digit octal (0777) not decimal permissions\n" . "$here\n" . $stat_real); -- 2.15.1