From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752686AbdLKLeS (ORCPT ); Mon, 11 Dec 2017 06:34:18 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:49455 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752208AbdLKLeR (ORCPT ); Mon, 11 Dec 2017 06:34:17 -0500 From: Arnd Bergmann To: Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com Cc: Arnd Bergmann , Jens Axboe , Hannes Reinecke , Bart Van Assche , NeilBrown , Mikulas Patocka , Dan Williams , Damien Le Moal , linux-kernel@vger.kernel.org Subject: [PATCH] dm: fix uninitialized variable reference Date: Mon, 11 Dec 2017 12:33:45 +0100 Message-Id: <20171211113358.3599287-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:eanmzdg3vfEiqPyNnb+Jr2Yp713M19J/r6ndQ+tngcloPp7OppW kJgXk0beDDC2sDmNkM0izZKKmGTqMNKXRJTHJKQso6NJ7Rt3piiqONwuFQpbh2/snZK3rHY hPZk48wmdFphw69nM8nUd95ChvBsAobIqcwbSFi4FEGgHc0lATQ70meiRgG7MEM2PwHeJj0 TN5TcKPAImBxHjk5xxtEQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:ba3m0z6L+90=:OF/C6i6182SoHv+JnJBfTl BZyITqB+OPV0NUIlW8FKdkiJGu9DsKdPsfsF0rRS0cTrKIYXHhSpxFLMgRxsqqhdCuAYCxYMg bgbfoq3nR1AWffUosmo/BGsEnrKLWqIqMhcstsRILJKlCJJ8vG2rqz2kCgU2coK2v2HCO73nO NAvhmjU2ZOw8VakjVo4poh5pAvqBHz+7szTd+g4Ca/zVrhrvpsD5YZIcpkxp01Gp9i1u3tsRR p+QSX+p6PxJWjBk+sbJVuY77oBmdnRcQetsyrKSB0So3bD07athymvVmT8mnK8QD09cZAWqi+ bO6I3Cs57gqhaqx/6KHd5QIyIUV2pfekWi1hX/M2ItxoxJo/NlI1El2BgCMAZOvU5O8r4yz66 bDSVMvpzjuJofbZRARBLpgEM9uvSzQoz2CAUYAdiO97UDf3id65p5UjHyT11W6asRgdEtXYQD 6VKAvW4Z3r+OI8ejD9AiC1+HQpFhrJ5ZI5uJsyYIv/HCX3GgL3kaWNGFM7oRNA8jP+LWc+ygc SNk+OcKj91PnQvBP1SSlj//4BAg6u9imeLeRF9hM3E9dNQE0jDMxsB5Hl7Xk+RXmui2IlMYMJ zZ+n6Z22M0uvtkapJA41jjmBMy77sxNwy2SKwDX+CDnNmyii03y/XDpOs3+G8c3wl6iJrhJdM SMTDmFCUOPgcr6oTL17agozTAmPstYoARROxU/FcLbzl3fqL2R0tTdLEUVHgoMkVHgt/Kaa1c o16OeZ0i/+3aq4ksJw+U/Rnx1KkOMMXi5/4JAQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The last bugfix apparently introduced another problem, as shown by this gcc warning: drivers/md/dm.c: In function '__send_changing_extent_only': drivers/md/dm.c:1365:28: error: 'ti' is used uninitialized in this function [-Werror=uninitialized] This restores the intialization of the 'ti' variable. Fixes: aecefd4919de ("dm: fix __send_changing_extent_only() to send first bio and chain remainder") Signed-off-by: Arnd Bergmann --- I did not test this or give the patch much thought, this just seemed to be the most likely fix I could come up with in a short time, so please review carefully, and ignore if the solution is something else. --- drivers/md/dm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 05aa9c094352..f19e9787076e 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -1356,6 +1356,10 @@ static int __send_changing_extent_only(struct clone_info *ci, unsigned len; unsigned num_bios; + ti = dm_table_find_target(ci->map, ci->sector); + if (!dm_target_is_valid(ti)) + return -EIO; + /* * Even though the device advertised support for this type of * request, that does not mean every target supports it, and -- 2.9.0