From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753108AbdLKNqt (ORCPT ); Mon, 11 Dec 2017 08:46:49 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:48680 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbdLKNqr (ORCPT ); Mon, 11 Dec 2017 08:46:47 -0500 Date: Mon, 11 Dec 2017 13:46:27 +0000 From: Russell King - ARM Linux To: Masami Hiramatsu Cc: Kunihiko Hayashi , Mark Rutland , Andrew Lunn , Florian Fainelli , devicetree@vger.kernel.org, netdev@vger.kernel.org, Linux kernel mailing list , Masahiro Yamada , Rob Herring , Philippe Ombredanne , Jassi Brar , "David S. Miller" , linux-arm-kernel Subject: Re: [PATCH net-next v5 2/2] net: ethernet: socionext: add AVE ethernet driver Message-ID: <20171211134627.GU10595@n2100.armlinux.org.uk> References: <1512979049-15930-3-git-send-email-hayashi.kunihiko@socionext.com> <20171211210455.170A.4A936039@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 11, 2017 at 10:34:17PM +0900, Masami Hiramatsu wrote: > IMHO, even if we use SPDX license identifier, I recommend to use > C-style comments as many other files do, since it is C code. > If SPDX identifier requires C++ style, that is SPDX parser's issue > and should be fixed to get it from C-style comment. See the numerous emails on this subject already. The issue of C vs C++ comments has come up many times by many different people, but the result is the same. That's not going to happen. Linux kernel C files are required to use "//" for the SPDX identifier by order of Linus Torvalds. Linus has also revealed in that discussion that he has a preference for "//" style commenting for single comments, so it seems that the kernel coding style may change - but there is no desire for patches to "clean up" single line comments to use "//". For further information, and to see the discussion that has already happened, the arguments that have been made about style, see the threads for the patch series that tglx has been posting wrt documenting the SPDX stuff for the kernel. Thanks (let's stop rehashing the same arguments.) -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up