From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752326AbdLKPMj (ORCPT ); Mon, 11 Dec 2017 10:12:39 -0500 Received: from mail-qt0-f194.google.com ([209.85.216.194]:36206 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678AbdLKPMh (ORCPT ); Mon, 11 Dec 2017 10:12:37 -0500 X-Google-Smtp-Source: ACJfBoukEIPXCWF//nNuRp4TC1VEvF9uLq7riaV0H58sp3nBl7PEP9iOq5OILBb7Hu3gVubn+irjUg== Date: Mon, 11 Dec 2017 07:12:34 -0800 From: Tejun Heo To: Ma Shimiao Cc: lizefan@huawei.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cgroup: avoid cgroup root name longer than max Message-ID: <20171211151234.GE2421075@devbig577.frc2.facebook.com> References: <20171208084746.5793-1-mashimiao.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171208084746.5793-1-mashimiao.fnst@cn.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 08, 2017 at 04:47:46PM +0800, Ma Shimiao wrote: > cgroup root name has max length limit, we should avoid copying > longer name than that to the name. > > Signed-off-by: Ma Shimiao > --- > kernel/cgroup/cgroup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c > index 0b1ffe147f24..3614a21ad6b8 100644 > --- a/kernel/cgroup/cgroup.c > +++ b/kernel/cgroup/cgroup.c > @@ -1866,7 +1866,7 @@ void init_cgroup_root(struct cgroup_root *root, struct cgroup_sb_opts *opts) > if (opts->release_agent) > strcpy(root->release_agent_path, opts->release_agent); > if (opts->name) > - strcpy(root->name, opts->name); > + strncpy(root->name, opts->name, MAX_CGROUP_ROOT_NAMELEN); Ditto here, let's use strscpy(). Thanks. -- tejun