From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751554AbdLKXZq (ORCPT ); Mon, 11 Dec 2017 18:25:46 -0500 Received: from ms.lwn.net ([45.79.88.28]:56158 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbdLKXZp (ORCPT ); Mon, 11 Dec 2017 18:25:45 -0500 Date: Mon, 11 Dec 2017 16:25:43 -0700 From: Jonathan Corbet To: Randy Dunlap Cc: Ingo Molnar , Peter Zijlstra , LKML , Al Viro Subject: Re: sched: Update kerneldoc for sched_rr_get_interval() Message-ID: <20171211162543.0e137538@lwn.net> In-Reply-To: <99d60c0c-270a-9595-898f-02f0ddbf4833@infradead.org> References: <20171211155651.7b098034@lwn.net> <99d60c0c-270a-9595-898f-02f0ddbf4833@infradead.org> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Dec 2017 15:14:21 -0800 Randy Dunlap wrote: > On 12/11/2017 02:56 PM, Jonathan Corbet wrote: > > Commit abca5fc535a3e ("sched_rr_get_interval(): move compat to native, get > > rid of set_fs()") changed the prototype of that function but left the > > kerneldoc comments unchanged, leading to these docs-build warnings: > > > > ./kernel/sched/core.c:5113: warning: No description found for parameter 't' > > ./kernel/sched/core.c:5113: warning: Excess function parameter 'interval' > > description in 'sched_rr_get_interval' > > > > Update the documentation (noting that it's not a user-space address > > anymore) and make the docs build a little quieter. > > > > Signed-off-by: Jonathan Corbet > > I sent a patch for this on DEC-03 to Al, Ingo, PeterZ, and LKML. > https://marc.info/?l=linux-kernel&m=151233595424349&w=2 > > or I could ack your patch. :) OK, looking more closely, your patch is more correct than mine and is the one that should be applied. Sorry I didn't see it before. jon