From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752232AbdLLEIf (ORCPT ); Mon, 11 Dec 2017 23:08:35 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:60865 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752041AbdLLEId (ORCPT ); Mon, 11 Dec 2017 23:08:33 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20171212040832epoutp043319a03746ac2195f5bd8a3cf3f8d8a1~-cIQA6YjO1276212762epoutp04O X-AuditID: b6c32a4b-cf7ff700000011c1-30-5a2f563f288c Mime-Version: 1.0 Subject: RE: Re: ftrace/module: Move ftrace_release_mod() to ddebug_cleanup label Reply-To: a.sahrawat@samsung.com From: AMIT SAHRAWAT To: Steven Rostedt , NAMIT GUPTA CC: "mingo@redhat.com" , "linux-kernel@vger.kernel.org" , PANKAJ MISHRA X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <20171211094219.1f08c7f2@vmware.local.home> X-Drm-Type: Y,confirm X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20171212034917epcms5p44bc4a77764ca9bf4f994aecc15e96116@epcms5p4> Date: Tue, 12 Dec 2017 03:49:17 +0000 X-CMS-MailID: 20171212034917epcms5p44bc4a77764ca9bf4f994aecc15e96116 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: REQ_APPROVE X-MTR: 20171212034917epcms5p44bc4a77764ca9bf4f994aecc15e96116 CMS-TYPE: 105P X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0hTYRjm2zmbR2l13LReJ9k4GZG6y5mbzsqKkhiYZVhRRulJPzZrF9nZ 7EI/jEpLSrpSWqn9qVDIssxbjTXB0shgYUSZSWh0k9EV7ELt7CT17/kenud7nvflpQjFb6mK KnN6sNvJ2RlZDHmrd8F8zdINukJ91R29+a7/gdT8uPu8zBz0N0nMIx/aJWbfoVHJMqnlgO9Z lCXkG5JZam82I8vntqR8shAvtmGuFLvV2FniKi1zWrOZ3IKiFUWmDD2rYbPMmYzayTlwNpOz Kl+zsswezmXUFZzdG6byOZ5ndEsWu11eD1bbXLwnm9nMsgYtq8/UGgwGrdG0ZaHBFJYUY9uj j+ek5X3KXTffDqJKNDGjBkVTQBvhWt2ktAbFUAq6B8H+YD9RgyhKTsfCr06loFHSBTBcN4IE rKDV0HPhaZTIa+F7Q7tUwDI6DaqOXpQJOI5eCy2NYxGeoI8huP5km5glh7PV46SIE6HjcjsS oqJpMwz8zBPpePhZOSWJh1BfIxJxHBwceUiIOBZGJ3siVuGbsXuE0B7oSwiGD4RI8dGKYPDV 5F9zJjzqb4yY5XQeXH35JdKTpOfB5U9vZKImB4K1X0ix8xzomDgfWQNBL4DWbp0omQ2nB65K RJwN48Pn/o44HY7+GJNMjdjZIGChWzKETqaJtAqqD58iRNoCHaG0Y4ip/7fm+v9i6//FNiGi GSXgct5hxbypPN2Jd2p5zsF7nVZticvRhiLHl5LbidoGVwUQTSFmmvxajbZQIeUq+N2OAAKK YOLkptWaQoW8lNu9B7tdRW6vHfMBZAov4Dihii9xhU/Z6SlijVl6Y0ZGJqvXZxmZWfK+Lu8m BW3lPHgHxuXYPeWTUNGqSrT9SP+sG3NTVbc1W9HQ6nWJOqUheOVdij8+78lgtf+78lvrPtPX h97k5S26pSt0J0ZjXnftTR2wccVtZ2o1VLGvl5wYNnjtBUP9bzemRg0ldkGVv873/H1gDRt7 P7C3Kch+JK05e5K+rm1NWD8z/cVYwjhUrLvQvaj318yk5emfGJK3cWwK4ea5PwqWv8eSAwAA DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171115095144epcas5p38455d1efc3aab5d80caa640583c9587c X-RootMTR: 20171115095144epcas5p38455d1efc3aab5d80caa640583c9587c References: <20171211094219.1f08c7f2@vmware.local.home> <1510739334-11334-1-git-send-email-gupta.namit@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steven, >> ftrace_module_init happen after dynamic_debug_setup, it is desired that >> cleanup should be called after this label however in current implementation >> it is called in free module label,ie:even though ftrace in not initialized, >> from so many fail case ftrace_release_mod() will be called and unnecessary >> traverse the whole list. >> In below patch we moved ftrace_release_mod() from free_module label to >> ddebug_cleanup label. that is the best possible location, other solution >> is to make new label to ftrace_release_mod() but since ftrace_module_init() >> is not return with minimum changes it should be in ddebug_cleanup label. >> >> >> Signed-off-by: Namit Gupta >> Reviewed-by: Amit Sahrawat > >Linus really looks down on this type of "Reviewed-by" tags. They are >meaningless. When a patch first shows up on the mailing list, it should >never have a "Reviewed-by" tag to it. Because to the maintainers, it >has not had a chance to be reviewed. We don't care about internal >company reviews. What should have happened, was this email goes to the >mailing list, and then Amit can reply to that email with a >"Reviewed-by", and any comments that Amit may have had. One reason that >we dislike internal reviews, is that we don't know what was discussed. >Since the review discussion is hidden, so should the tag. > I fully agree to what you say and the overall perspective for the open source. When i consider the situation, it was reviewed for our internal issue fixing and adopting to our kernel. And with respect to "internal reviews" it ended there itself. After adopting it was realized to push this to open source as well. Which as a policy is correct, but the submission method went wrong. May be it is first patch from Namit and i did not notice due to our mail client. >Since the email was missing a "[PATCH]" in the subject, that means Amit >missed that too, and also takes the blame. Yes, i did not notice that in my mailbox as well. It can just be put to my skipping of this mail as the code was finalized for internal purpose, i did not notice that the external patch is having "Reviewed-by" and obviously the subject as you mentioned [PATCH] was missing from it. I am aware of the guidelines and method for contribution, this particular patch submission can be put to my ignorance. So, I take the blame for this as well. Thanks & Regards, Amit Sahrawat