From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751663AbdLLHr2 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 02:47:28 -0500
Received: from mx2.suse.de ([195.135.220.15]:38371 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750715AbdLLHrZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 02:47:25 -0500
Date: Tue, 12 Dec 2017 08:47:22 +0100
From: Michal Hocko <mhocko@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm, hugetlbfs: include mm.h for vm_operations_struct
Message-ID: <20171212074722.GG4779@dhcp22.suse.cz>
References: <20171211162243.233177-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171211162243.233177-1-arnd@arndb.de>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon 11-12-17 17:21:27, Arnd Bergmann wrote:
> The infiniband umem code causes a build failure in some configurations:
> 
> In file included from drivers/infiniband/core/umem_odp.c:41:0:
> include/linux/hugetlb.h: In function 'vma_kernel_pagesize':
> include/linux/hugetlb.h:262:32: error: dereferencing pointer to incomplete type 'const struct vm_operations_struct'
> 
> Including the header file that defines the structure is sufficient to
> avoid this.
> 
> Fixes: ac9284a6b670 ("mm, hugetlbfs: introduce ->pagesize() to vm_operations_struct")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I've tried to do the same but the compilation failed for other
arches/configs. See http://lkml.kernel.org/r/20171210113715.GE20234@dhcp22.suse.cz

> ---
>  include/linux/hugetlb.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index b0f1f6768336..082ff47201be 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -9,6 +9,7 @@
>  #include <linux/cgroup.h>
>  #include <linux/list.h>
>  #include <linux/kref.h>
> +#include <linux/mm.h>
>  #include <asm/pgtable.h>
>  
>  struct ctl_table;
> -- 
> 2.9.0
> 

-- 
Michal Hocko
SUSE Labs