From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752625AbdLLKSi (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 05:18:38 -0500
Received: from mail-wm0-f68.google.com ([74.125.82.68]:45474 "EHLO
        mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752570AbdLLKSW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 05:18:22 -0500
X-Google-Smtp-Source: ACJfBotpOnBANCKNiYGIUgaQOYp23vtoVhJ7D6H2l66yfTfidIJ08uOQV0BiIWNm5YkyjVYzZpuV2w==
Date: Tue, 12 Dec 2017 11:18:19 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Randy Dunlap <rdunlap@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>, Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: sched: Update kerneldoc for sched_rr_get_interval()
Message-ID: <20171212101819.oq3mtmifqbovytgh@gmail.com>
References: <20171211155651.7b098034@lwn.net>
 <99d60c0c-270a-9595-898f-02f0ddbf4833@infradead.org>
 <20171211162543.0e137538@lwn.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171211162543.0e137538@lwn.net>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Jonathan Corbet <corbet@lwn.net> wrote:

> On Mon, 11 Dec 2017 15:14:21 -0800
> Randy Dunlap <rdunlap@infradead.org> wrote:
> 
> > On 12/11/2017 02:56 PM, Jonathan Corbet wrote:
> > > Commit abca5fc535a3e ("sched_rr_get_interval(): move compat to native, get
> > > rid of set_fs()") changed the prototype of that function but left the
> > > kerneldoc comments unchanged, leading to these docs-build warnings:
> > > 
> > >   ./kernel/sched/core.c:5113: warning: No description found for parameter 't'
> > >   ./kernel/sched/core.c:5113: warning: Excess function parameter 'interval'
> > >   			      description in 'sched_rr_get_interval'
> > > 
> > > Update the documentation (noting that it's not a user-space address
> > > anymore) and make the docs build a little quieter.
> > > 
> > > Signed-off-by: Jonathan Corbet <corbet@lwn.net>  
> > 
> > I sent a patch for this on DEC-03 to Al, Ingo, PeterZ, and LKML.
> > https://marc.info/?l=linux-kernel&m=151233595424349&w=2
> > 
> > or I could ack your patch.  :)
> 
> OK, looking more closely, your patch is more correct than mine and is the
> one that should be applied.  Sorry I didn't see it before.

Yeah, I have applied Randy's patch to the sched/urgent tree yesterday:

  2064a5ab0470: sched/core: Fix kernel-doc warnings after code movement

It's still not pushed out though, because I'm chasing an (unrelated) regression.

Thanks,

	Ingo