From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755394AbdLLNFw (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 08:05:52 -0500
Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:35408 "EHLO
        mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1755000AbdLLNFs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 08:05:48 -0500
Authentication-Results: ppops.net;
        spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com
Date: Tue, 12 Dec 2017 13:04:01 +0000
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Steven Eckhoff <steven.eckhoff.opensource@gmail.com>
CC: <alsa-devel@alsa-project.org>, Liam Girdwood <lgirdwood@gmail.com>,
        "Mark Brown" <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's
 TSCS42xx audio CODEC
Message-ID: <20171212130401.nugvjnko6x3c3apn@localhost.localdomain>
References: <20171211195403.3irxp7g3n326ub3g@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20171211195403.3irxp7g3n326ub3g@localhost.localdomain>
User-Agent: NeoMutt/20170113 (1.7.2)
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0
 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011
 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000
 definitions=main-1712120189
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote:
> Currently there is no support for the TSCS42xx audio CODEC.
> 
> Add support for it.
> 
> v5 attempts to address all issues raised in the previous reviews.
> 
> Thank you to everyone who has invested their time reviewing these
> patches.
> 
> Acked-by: Philippe Ombredanne <pombredanne@nexb.com>
> Signed-off-by: Steven Eckhoff <steven.eckhoff.opensource@gmail.com>
> ---
> +int bytes_tlv_callback(struct snd_kcontrol *kcontrol, int op_flag,
> +	unsigned int size, unsigned int __user *tlv)
> +{
> +	struct tscs_dsp_ctl *ctl =
> +		(struct tscs_dsp_ctl *)kcontrol->private_value;
> +	struct soc_bytes_ext *params = &ctl->bytes_ext;
> +	unsigned int count = size < params->max ? size : params->max;
> +	int ret = -ENXIO;
> +
> +	switch (op_flag) {
> +	case SNDRV_CTL_TLV_OP_READ:
> +		if (params->get)
> +			ret = params->get(kcontrol, tlv, count);
> +		break;
> +	case SNDRV_CTL_TLV_OP_WRITE:
> +		if (params->put)
> +			ret = params->put(kcontrol, tlv, count);
> +		break;
> +	}
> +	return ret;
> +}

Should this function be removed, I am assuming it is a hang over
from the earlier TLV implementation?

Thanks,
Charles