From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752861AbdLLPBY (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 10:01:24 -0500
Received: from mail.kernel.org ([198.145.29.99]:36536 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752773AbdLLPBU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 10:01:20 -0500
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F6E120740
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org
Date: Tue, 12 Dec 2017 12:01:17 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: bhargavb <bhargavaramudu@gmail.com>, linux-kernel@vger.kernel.org,
        Paul Clarke <pc@us.ibm.com>,
        Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
        Thomas Richter <tmricht@linux.vnet.ibm.com>,
        linux-rt-users@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v3 5/5] perf-probe: Support escaped character in parser
Message-ID: <20171212150117.GM3958@kernel.org>
References: <151275037752.24652.5169845651138876257.stgit@devbox>
 <151275052163.24652.18205979384585484358.stgit@devbox>
 <20171211200330.GI3958@kernel.org>
 <20171212234600.a54ef5601cb4dfdf49e41826@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171212234600.a54ef5601cb4dfdf49e41826@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Tue, Dec 12, 2017 at 11:46:00PM +0900, Masami Hiramatsu escreveu:
> On Mon, 11 Dec 2017 17:03:30 -0300
> Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > > -		/* We don't care about default symbol or not */
> > > -		ver = strchr(norm, '@');
> > > -		if (ver) {
> > > -			buf = strndup(norm, ver - norm);
> > > -			if (!buf)
> > > -				return -ENOMEM;
> > > -			norm = buf;
> > > +		if (cut_version) {
> > > +			/* We don't care about default symbol or not */
> > > +			ver = strchr(norm, '@');
> > > +			if (ver) {
> > > +				buf = strndup(norm, ver - norm);
> > > +				if (!buf)
> > > +					return -ENOMEM;
> > > +				norm = buf;

> > You forgot a } here, please check this logic and resubmit just this last
> > patch, without the string.c and string2.h part, that I already split
> > from this one and applied.
 
> OOPS! thanks! I missed something around that.... maybe while updating patches.
> Hmm, I might be so upset...
 
> OK, anyway, I'll do that. 

Nah, happens sometimes, one last round of building before submitting
would catch that tho... 8-) :-)

- Arnaldo