Re: [PATCH] regmap: allow to disable all locking mechanisms

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

On Tue, Dec 12, 2017 at 01:21:46PM +0100, Bartosz Golaszewski wrote:
> 2017-12-12 13:18 GMT+01:00 Mark Brown <broonie@kernel.org>:

> > That's true, and the debugfs is world readable too so we can't just say
> > it's up to root to be sensible.

> This lock is only taken when writing to cache_only and cache_bypass though.

No, that's not the case at all.  Most obviously userspace can also
initiate read operations from debugfs.

> Maybe the right approach would be to provide users with locking
> routines (regmap_lock()/regmap_unlock()) and then add a boolean
> variable to the config (e.g. bool manual_locking) which would indicate
> to regmap that it shouldn't take the lock in most cases (except for
> debugfs) as this would be manually done by the regmap owner?

The most obvious thing is just to do what Lars suggested and suppress
the creation of the debugfs entries for the device when locking is
disabled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]