mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Derald D. Woods" <woods.technical@gmail.com>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: linux-omap@vger.kernel.org, tony@atomide.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: omap3-evm: Fix missing NAND partition information
Date: Tue, 12 Dec 2017 10:31:26 -0600	[thread overview]
Message-ID: <20171212163125.GA8032@DeraldWoods-PC.wicab.com> (raw)
In-Reply-To: <20171212063930.GA2791@lenoch>

On Tue, Dec 12, 2017 at 07:39:30AM +0100, Ladislav Michl wrote:
> On Mon, Dec 11, 2017 at 10:12:13PM -0600, Derald D. Woods wrote:
> > The partition information was omitted during the conversion to OMAP3430
> > specific data.
> 
> That could be intentional...

I am fixing an addition that I created.

> 
> > The data added by this commit is consistent with current U-Boot default
> > definitions.
> 
> What about passing U-Boot partitions information to kernel instead?
> 

I am testing using an appended device-tree. This has been the most
reliable method for the OMAP34XX boards that I have. If you have an
example config, with working command line MTDPARTS, for beagleboard(Rev.
C4), Overo TOBI, or similiar OMAP34XX, I will gladly use it. Also note
that other OMAP34XX boards currently provide a default partition
layout. Is that bad practice for all of those as well? I am open to
exploring the method that actually works.

- Derald


> > Fixes: 62fe1d337461 ("ARM: dts: omap3-evm: Add OMAP3530 specific device
> > tree processor data")
> > 
> > Signed-off-by: Derald D. Woods <woods.technical@gmail.com>
> > ---
> >  arch/arm/boot/dts/omap3-evm.dts | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/omap3-evm.dts b/arch/arm/boot/dts/omap3-evm.dts
> > index 21a3b88aef0c..1220deb47aae 100644
> > --- a/arch/arm/boot/dts/omap3-evm.dts
> > +++ b/arch/arm/boot/dts/omap3-evm.dts
> > @@ -85,5 +85,30 @@
> >  
> >  		#address-cells = <1>;
> >  		#size-cells = <1>;
> > +
> > +		partition@0 {
> > +			label = "spl";
> > +			reg = <0 0x80000>;
> > +		};
> > +		partition@80000 {
> > +			label = "u-boot";
> > +			reg = <0x80000 0x1c0000>;
> > +		};
> > +		partition@240000 {
> > +			label = "dtb";
> > +			reg = <0x240000 0x20000>;
> > +		};
> > +		partition@260000 {
> > +			label = "u-boot-env";
> > +			reg = <0x260000 0x20000>;
> > +		};
> > +		partition@280000 {
> > +			label = "kernel";
> > +			reg = <0x280000 0x600000>;
> > +		};
> > +		partition@880000 {
> > +			label = "rootfs";
> > +			reg = <0x880000 0>;
> > +		};
> >  	};
> >  };
> > -- 
> > 2.15.1
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-12-12 16:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-12  4:12 Derald D. Woods
2017-12-12  6:39 ` Ladislav Michl
2017-12-12 16:31   ` Derald D. Woods [this message]
2017-12-12 16:55     ` Tony Lindgren
2017-12-12 17:50       ` Ladislav Michl
2017-12-12 18:08         ` Derald D. Woods
2017-12-12 18:15           ` Tony Lindgren
2017-12-12 18:24             ` Derald D. Woods
2017-12-12 18:40               ` Ladislav Michl
     [not found]                 ` <CAHCN7xKn2-6NVhy6MegJgEZrF3=DFigvHW6xf0Gb2BFRTJMDNw@mail.gmail.com>
2017-12-13 13:44                   ` Derald D. Woods
2017-12-13 15:05                     ` Ladislav Michl
2017-12-13 15:37                       ` Derald D. Woods
2017-12-12 17:03     ` Ladislav Michl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171212163125.GA8032@DeraldWoods-PC.wicab.com \
    --to=woods.technical@gmail.com \
    --cc=ladis@linux-mips.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®