From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752567AbdLLQv7 (ORCPT ); Tue, 12 Dec 2017 11:51:59 -0500 Received: from mail-co1nam03on0062.outbound.protection.outlook.com ([104.47.40.62]:38991 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751665AbdLLQv5 (ORCPT ); Tue, 12 Dec 2017 11:51:57 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Yazen.Ghannam@amd.com; From: Yazen Ghannam To: linux-edac@vger.kernel.org Cc: Yazen Ghannam , Borislav Petkov , Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] x86/mce: Do Deferred error check for CEC Date: Tue, 12 Dec 2017 10:51:43 -0600 Message-Id: <20171212165143.27475-1-Yazen.Ghannam@amd.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: DM5PR1101CA0011.namprd11.prod.outlook.com (10.174.246.21) To DM5PR1201MB0139.namprd12.prod.outlook.com (10.174.106.144) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6e661f90-adcf-41c7-818d-08d54180a6a6 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(48565401081)(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307);SRVR:DM5PR1201MB0139; X-Microsoft-Exchange-Diagnostics: 1;DM5PR1201MB0139;3:f2ZkchAefO4bfPL1/v4y5cI1eU7VYPr6fN1cwYOpSnKkE9mbmVL5vDwkz75F+z3Q0M+Sv5wgfMUzbeBdmtMp0INq0ZJdEU+v5ES8Ups8ACyncG2vvKb60VtzTiUxr4G3Cx//WqesTw+cibvu09M3Q7NX6kf7Qoz86uwoDxB3qGDKdM55i4CE5LOkZ+Z1hkmLLVmZ/ebcCOm6TduQroff9dBLez3jJBRBK8vpvBiO1ubzczNvxn/QMw1Ni9PS1yGj;25:A/J427Q3KKNL8Qq82W9X2l32leEKGxhNsT+niCO/OUiHu24Kd/8kQhGXXE3B/Sf5f4UR9no7Nbed6d+uWVLoistGDyO4S26i0Zbk9Wj5KkVu0oAyzuvX/M9bJpYh3KKc3qdOIEo1X1Sp1/RtmsqY2aPaMmUmsgJCzhjwHTXEhhHe1jOth6bN0rE8Lssp03Ooxkri9cdnZ6ecyChxYrdB7JSYdT1MAZPFa8G2oRP+DpDkENAzYBl+PR0M66TOUVsSxiMx3dx4dm6frmQeNHTI5sGswRaMep4jhFHxnMhT44NCxvi9U3k05gA2R30X8k4ESB+1mKPYMr1hKjG5ft4eKA==;31:SA5DQ0eB9QLblBRr2wVonKEllFzkndAjwlHjNt9OM35Uz2luIspQ1Wpw8rMONHMK8ek+Yf0Z5oR78Twt8GGYGFSJdXRk6bDp9461ETBlx422mmn03RC1Y85FsM4ZLmaVRyGfsmtO8g7NNHB65tSnCj/JsEOUN4RU9kF4jx+qOzN5S2sOd59bGSu9AgNHyncGEQGmZiFMXCbEXDrXh96PrZE8YOGv1H3i8LscsFkXv54= X-MS-TrafficTypeDiagnostic: DM5PR1201MB0139: X-Microsoft-Exchange-Diagnostics: 1;DM5PR1201MB0139;20:uO0AS3nI3UtM2ypWI0sj3+7lusxn5g+KxoBSkCaFocSvvC/UiuF3oBSDRKTBZ7+0W0kDzWnc+idIggvmd0Hy1o0gosf3veS/A+3uhxCFtKuc44FRvT4D9fVAG4hl+79EXTyMqngkz89xGcBI4PZeHd1v9lIY8Ldlf5ZJreyhjW4J7nJzDGNEpYlEgStUlBfBZktmWATSkBDQ2kvp36IQUb89J1NvD8oub6MVfV+YuFovJbQpKyLfNe0iF/ZFmW51Xob9esQtxpmuJiRmJKSzcmWP+p7j9x3nyo8+7apkkWa17g1xOzPa8i1oDlz1Z0Wb7KhY/UQu6AUULm6GbFSsb8XpgLNV9B1zdOJylWVjKYlve6dKhFdSzky2DH0Ih/rFIuDESon4Z4uSyoXYNn+p9QzqSGCuxk5+tkTfCyYHe9VPEhcZjNsxg9We9m75ZLnU+ZFra1U9f77oStlNYEf3kcXPvvlAALA/Nq15DH48odGbvamMoyzvi1Hh/Hbyz+PN;4:cNeMNFPniGukwg/idlDvDXe0EJ4G/XfhpQV7FEZgp9liVCHoWsxXT7O9//XgTJVK84SX0nJR3MCUnw6rb3aK68PzwpGaN3Yyx3IuI4pXrf14XWdLgIqrXuASbvwi1OUJiNZgnPfErOcNaylq1yLilx/ZUfCcQxqp8lyz8l0Bt2j04QlUXXmTmGcJA7mSkVGPp5QbKKiq0FS3gwfdUK570h9UaCNGTENCJyM0yjtFMI+acn+A8SJPa/paGu/4rwS0Dw+2VKcix9zlMJNwFcIiHhdE4qBdCJLuDo2hKRXkiBK7iG/uqNvmCUlpJQCeETEKrngqHgciCjtmAn6yN8m8gw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231023)(6055026)(6041248)(20161123564025)(20161123558100)(20161123562025)(20161123555025)(201703131423075)(201703011903075)(201702281528075)(201703061421075)(20161123560025)(6072148)(201708071742011);SRVR:DM5PR1201MB0139;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DM5PR1201MB0139; X-Forefront-PRVS: 051900244E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(7966004)(376002)(346002)(39860400002)(366004)(189003)(199004)(81166006)(53416004)(81156014)(4326008)(6916009)(6666003)(106356001)(105586002)(36756003)(16586007)(6486002)(316002)(305945005)(7736002)(68736007)(97736004)(54906003)(8676002)(1076002)(25786009)(508600001)(8936002)(66066001)(72206003)(48376002)(50466002)(59450400001)(5660300001)(2906002)(16526018)(2361001)(2351001)(6116002)(53936002)(47776003)(51416003)(50226002)(7696005)(86362001)(52116002)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR1201MB0139;H:yaz-diesel.amd.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR1201MB0139;23:RnVtP58bKfgCycYMTVmdVTKZW4nfHTdVLlCpgM6?= =?us-ascii?Q?WAR6mpcK2bAsv2vn3RE3BSQPJOlQcHBkxtJKCX7b3Aws84Lz1u9jK5aeWFPM?= =?us-ascii?Q?/3lOFFXNHQjJIk58j12LbJsxAKojX0QizMOTNBEQfbVDQ+70HRQX+flishgx?= =?us-ascii?Q?7JesXXgyxOyrINRWoA93A34C25bwtQVxXKr70aRO0Q8HPJPDatLjpYM6cnQ2?= =?us-ascii?Q?xQGxuGH0+PWWx2X7SWJQlYFAAPPJLTtv8bWtY+pd2x7krEtGZCBn3/43xdIw?= =?us-ascii?Q?rxkUuMqxK825y20kIki7Znp3K4TrsYLVit7mQuMxvJG1CtNgZTz4tWvf0D4d?= =?us-ascii?Q?ezfiRD2DyAcMTz36RChAcVlKPjH+hUdHYQ30oZoGjHc9lTrg80xtsYyCnV+q?= =?us-ascii?Q?hgVkDL2UFUEr2hcmhKCLmLqxiKPYMNDCpj1LcCH7BQAFEMSpVI9rXEAeDJMT?= =?us-ascii?Q?EAtzFfgAAhWD4x8eiZS9mWSeum3orPs2nXcArBzQ6GF+o6r3zhtvy8nxgSwg?= =?us-ascii?Q?PA0VPhrC103eDYdypG61CUKCwVqYxhYO69DsN/w4LYz1qKtHvKwQlGNKev82?= =?us-ascii?Q?lGR7in8OVSJwH4co5Yei2+aW9bXZbGx5WS7UtJ+ULWOUl39jjuaO3yppu01c?= =?us-ascii?Q?JLTDi/xOj4z5IZKVr9GVbmGylOSr9RzibB6peUpYxgO3eMzvRbc3xvECyaau?= =?us-ascii?Q?WVy/Sb0yZabzAFPygqWemhuygTX4IVXeHXRFHr8r9UH9TuvpFGEkh7F4yDOD?= =?us-ascii?Q?poiP4HJLllT4HDbqfqNO5LI2dtveeWyN+MKT1V0Vo/343NyXGKOB/9EWNms2?= =?us-ascii?Q?x2soxiHWwNDMiZpeteg25rGG43FWiFPnv5LAXjDS2gdCN7k9NL4wCuSxnTb/?= =?us-ascii?Q?1T25MIieJMru9XisCF3tXPcXoO6mcTXK/EqiptIQzE/EiQSLifTT7PZ7FWg1?= =?us-ascii?Q?D7xRtyMCsSabxuxrvftRmYzGl3/EzlNn9tOVOs+5pWrQDUIC8Fc5wexUiq/J?= =?us-ascii?Q?dfbLsGSrbRfxcrAMeAbenuibVE2PDPeTNZMqVzBdKCr1dbvRc6Ab9lioU/M1?= =?us-ascii?Q?Jlu98B1sDt2e2NWTcaFtjdQblg+IOSsIMk8UhKFSog9ZyeTDpbMPtBqTtOp7?= =?us-ascii?Q?shn8cbY+luEg=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR1201MB0139;6:kvzPiWcLBlaW7Ib/evwcx8fhivV2Ptfiim+pcGJkAjsXgUPmD2+L4xm6HE136pSKHoHnQICacj8NJlUZLNkLhxbAOeDN5MMyC0xNs6/hWJKMRPeJLR6vD7MUAIikEzPfBccIPpspIO2CdjX4R0PAPCdSw49HY6vMknrO8CRzZQbWBgZSTY2NF34seUmRo7FcLGnV83cHpzSA6dlsI8ApkIIsSfb4KwxeXrdsDnlTXVP74fOq0XcrrHFYD2yAzAU2TWpcwhYoqgJY63ccMcCZsiJtuOjRksaZd/zp9NuT02JzAIE868fEpGsEk/mbi/2ImGQcx17dxz8yoy2ahDuxvZf7efwYdKd5maCzNXN0qMY=;5:WzFWSopJhbQNQh9kbRfzV62T7XNszJS+qJCkdrOFajjwPAbrw3P/5JH2WQc6hadbe3/k7u7ooUJssBN1AQUb54P4IYe7UKZTjSPhf8frVtORu67hbJhw7RLZRtdJXuyInvW720+tCecbzMz5WsmiVLo06b1qs3oGPWQjF0ApCA0=;24:Ylvz3/Xw803/Rb5zXqBRA+UoiWjxMavsRbzuUG2Ez8MVEMoPL8+C3+Ms82vXR1p9xKG9lDQb1FgSz6XbVM/UcUMQ96Yo3IGmKDlx7244JDE=;7:L/+l8IV+w7jffkNTO2NEkXE1bl14YNrP2pPQ/JB7BXn0Jm5bXqQvpCkxeG1vLIwZ3XXdMoN2gB2CojinM7PqNV4Xfchrm27tEYFrUqioSPoSQ2PGZdF1AxTwpVVfBwUQ4iQ2hZCQqIf9By5HDuHM3usKPMMP074a2n8yPG2WINNf6FfyTws6Xofamz5stL7QWlknhc1n/kPJCVaBPeyHvKWmDP3QtcXfbJzvAjM5SId3C39ZlGJu3APfDVRwctq5 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR1201MB0139;20:VplJmHtef7+wco76NdquTGU3vEkoZi0ECM2+iqpce1SsOKDSGG4gvC5PJSs5KEbLXADwC4ZFbDN2yjVQBfx05CByBnL0lK2fIgTUajhensOXH4DfgNsZF0DsRoy0kQE1jQvp3i47C6LvBc36cCXUfigOSm6/VdjHEg5iz//dWs1IwEXY8a9jm0dnwcpeCVOiflgX+CuRnsDTmuPeQNmTIycEmJnycakbAU/csb3dSTPcUsi0i5+yzxBPqTRX6HxJ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2017 16:51:54.7998 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e661f90-adcf-41c7-818d-08d54180a6a6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0139 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yazen Ghannam AMD systems may log Deferred errors. These are errors that are uncorrected but which do not need immediate action. The MCA_STATUS[UC] bit may not be set for Deferred errors. Flag the error as not correctable when MCA_STATUS[Deferred] is set. Signed-off-by: Yazen Ghannam Cc: stable@vger.kernel.org # 4.13.x --- arch/x86/kernel/cpu/mcheck/mce.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c index 321c7a80be66..1b2c11473376 100644 --- a/arch/x86/kernel/cpu/mcheck/mce.c +++ b/arch/x86/kernel/cpu/mcheck/mce.c @@ -528,6 +528,17 @@ bool mce_is_memory_error(struct mce *m) } EXPORT_SYMBOL_GPL(mce_is_memory_error); +static bool mce_is_correctable(struct mce *m) +{ + if (m->cpuvendor == X86_VENDOR_AMD && m->status & MCI_STATUS_DEFERRED) + return false; + + if (m->status & MCI_STATUS_UC) + return false; + + return true; +} + static bool cec_add_mce(struct mce *m) { if (!m) @@ -535,7 +546,7 @@ static bool cec_add_mce(struct mce *m) /* We eat only correctable DRAM errors with usable addresses. */ if (mce_is_memory_error(m) && - !(m->status & MCI_STATUS_UC) && + mce_is_correctable(m) && mce_usable_address(m)) if (!cec_add_elem(m->addr >> PAGE_SHIFT)) return true; -- 2.14.1