From: alexander.levin@verizon.com
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: Patrice Chotard <patrice.chotard@st.com>,
Linus Walleij <linus.walleij@linaro.org>,
alexander.levin@verizon.com
Subject: [PATCH AUTOSEL for 4.9 029/100] pinctrl: st: add irq_request/release_resources callbacks
Date: Wed, 13 Dec 2017 01:57:29 +0000 [thread overview]
Message-ID: <20171213015722.6722-4-alexander.levin@verizon.com> (raw)
In-Reply-To: <20171213015722.6722-1-alexander.levin@verizon.com>
From: Patrice Chotard <patrice.chotard@st.com>
[ Upstream commit e855fa9a65c40788b5069abb0d094537daa22e05 ]
When using GPIO as IRQ source, the GPIO must be configured
in INPUT. Callbacks dedicated for this was missing in
pinctrl-st driver.
This fix the following kernel error when trying to lock a gpio
as IRQ:
[ 7.521095] gpio gpiochip7: (PIO11): gpiochip_lock_as_irq: tried to flag a GPIO set as output for IRQ
[ 7.526018] gpio gpiochip7: (PIO11): unable to lock HW IRQ 6 for IRQ
[ 7.529405] genirq: Failed to request resources for 0-0053 (irq 81) on irqchip GPIO
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
---
drivers/pinctrl/pinctrl-st.c | 30 ++++++++++++++++++++++++------
1 file changed, 24 insertions(+), 6 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index b7bb37167969..50c45bdf93be 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -1285,6 +1285,22 @@ static void st_gpio_irq_unmask(struct irq_data *d)
writel(BIT(d->hwirq), bank->base + REG_PIO_SET_PMASK);
}
+static int st_gpio_irq_request_resources(struct irq_data *d)
+{
+ struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
+
+ st_gpio_direction_input(gc, d->hwirq);
+
+ return gpiochip_lock_as_irq(gc, d->hwirq);
+}
+
+static void st_gpio_irq_release_resources(struct irq_data *d)
+{
+ struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
+
+ gpiochip_unlock_as_irq(gc, d->hwirq);
+}
+
static int st_gpio_irq_set_type(struct irq_data *d, unsigned type)
{
struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
@@ -1438,12 +1454,14 @@ static struct gpio_chip st_gpio_template = {
};
static struct irq_chip st_gpio_irqchip = {
- .name = "GPIO",
- .irq_disable = st_gpio_irq_mask,
- .irq_mask = st_gpio_irq_mask,
- .irq_unmask = st_gpio_irq_unmask,
- .irq_set_type = st_gpio_irq_set_type,
- .flags = IRQCHIP_SKIP_SET_WAKE,
+ .name = "GPIO",
+ .irq_request_resources = st_gpio_irq_request_resources,
+ .irq_release_resources = st_gpio_irq_release_resources,
+ .irq_disable = st_gpio_irq_mask,
+ .irq_mask = st_gpio_irq_mask,
+ .irq_unmask = st_gpio_irq_unmask,
+ .irq_set_type = st_gpio_irq_set_type,
+ .flags = IRQCHIP_SKIP_SET_WAKE,
};
static int st_gpiolib_register_bank(struct st_pinctrl *info,
--
2.11.0
next prev parent reply other threads:[~2017-12-13 1:58 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 1:57 [PATCH AUTOSEL for 4.9 026/100] r8152: fix the rx early size of RTL8153 alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 028/100] inet: frag: release spinlock before calling icmp_send() alexander.levin
2017-12-13 1:57 ` alexander.levin [this message]
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 027/100] tipc: fix nametbl deadlock at tipc_nametbl_unsubscribe alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 031/100] kvm: vmx: Flush TLB when the APIC-access address changes alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 030/100] scsi: lpfc: Fix PT2PT PRLI reject alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 033/100] KVM: VMX: Fix enable VPID conditions alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 032/100] KVM: x86: correct async page present tracepoint alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 034/100] ARM: dts: ti: fix PCI bus dtc warnings alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 037/100] HID: xinmo: fix for out of range for THT 2P arcade controller alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 036/100] i2c: mux: pca954x: Add missing pca9546 definition to chip_desc alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 038/100] ASoC: STI: Fix reader substream pointer set alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 035/100] hwmon: (asus_atk0110) fix uninitialized data access alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 040/100] s390/qeth: size calculation outbound buffers alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 039/100] r8152: prevent the driver from transmitting packets with carrier off alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 041/100] s390/qeth: no ETH header for outbound AF_IUCV alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 044/100] IB/core: Protect against self-requeue of a cq work item alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 043/100] i40iw: Receive netdev events post INET_NOTIFIER state alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 042/100] bna: avoid writing uninitialized data into hw registers alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 045/100] infiniband: Fix alignment of mmap cookies to support VIPT caching alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 049/100] IB/rxe: increment msn only when completing a request alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 046/100] nbd: set queue timeout properly alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 050/100] i40e: Do not enable NAPI on q_vectors that have no rings alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 047/100] net: Do not allow negative values for busy_read and busy_poll sysctl interfaces alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 048/100] IB/rxe: double free on error alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 052/100] irda: vlsi_ir: fix check for DMA mapping errors alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 053/100] netfilter: nfnl_cthelper: fix a race when walk the nf_ct_helper_hash table alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 051/100] RDMA/iser: Fix possible mr leak on device removal event alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 054/100] netfilter: nf_nat_snmp: Fix panic when snmp_trap_helper fails to register alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 056/100] cpufreq: Fix creation of symbolic links to policy directories alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 057/100] net: ipconfig: fix ic_close_devs() use-after-free alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 055/100] ARM: dts: am335x-evmsk: adjust mmc2 param to allow suspend alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 061/100] isdn: kcapi: avoid uninitialized data alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 059/100] virtio-balloon: use actual number of stats for stats queue buffers alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 058/100] KVM: pci-assign: do not map smm memory slot pages in vt-d page tables alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 060/100] virtio_balloon: prevent uninitialized variable use alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 062/100] net: moxa: fix TX overrun memory leak alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 064/100] netfilter: nfnetlink_queue: fix secctx " alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 063/100] xhci: plat: Register shutdown for xhci_plat alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 065/100] Btrfs: fix an integer overflow check alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 066/100] ARM: dma-mapping: disallow dma_get_sgtable() for non-kernel managed memory alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 068/100] bnxt_en: Fix NULL pointer dereference in reopen failure path alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 069/100] backlight: pwm_bl: Fix overflow condition alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 067/100] cpuidle: powernv: Pass correct drv->cpumask for registration alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 073/100] crypto: crypto4xx - increase context and scatter ring buffer elements alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 070/100] crypto: talitos - fix ctr-aes-talitos alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 072/100] crypto: talitos - fix memory corruption on SEC2 alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 071/100] crypto: talitos - fix AEAD test failures alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 075/100] kvm, mm: account kvm related kmem slabs to kmemcg alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 074/100] rtc: pl031: make interrupt optional alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 076/100] net: phy: at803x: Change error to EINVAL for invalid MAC alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 077/100] PCI: Avoid bus reset if bridge itself is broken alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 078/100] scsi: cxgb4i: fix Tx skb leak alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 080/100] PCI: Create SR-IOV virtfn/physfn links before attaching driver alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 081/100] PM / OPP: Move error message to debug level alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 079/100] scsi: mpt3sas: Fix IO error occurs on pulling out a drive from RAID1 volume created on two SATA drive alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 083/100] ixgbe: fix use of uninitialized padding alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 082/100] igb: check memory allocation failure alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 084/100] IB/rxe: check for allocation failure on elem alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 085/100] PCI/AER: Report non-fatal errors only to the affected endpoint alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 086/100] tracing: Exclude 'generic fields' from histograms alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 089/100] powerpc/xmon: Avoid tripping SMP hardlockup watchdog alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 087/100] percpu: don't forget to free the temporary struct pcpu_alloc_info alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 088/100] ASoC: img-parallel-out: Add pm_runtime_get/put to set_fmt callback alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 090/100] fm10k: fix mis-ordered parameters in declaration for .ndo_set_vf_bw alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 091/100] scsi: lpfc: Fix secure firmware updates alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 093/100] vfio/pci: Virtualize Maximum Payload Size alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 092/100] scsi: lpfc: PLOGI failures during NPIV testing alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 095/100] net: ipv6: send NS for DAD when link operationally up alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 096/100] staging: greybus: light: Release memory obtained by kasprintf alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 097/100] clk: sunxi-ng: sun6i: Rename HDMI DDC clock to avoid name collision alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 094/100] fm10k: ensure we process SM mbx when processing VF mbx alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 099/100] rtc: set the alarm to the next expiring timer alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 098/100] tcp: fix under-evaluated ssthresh in TCP Vegas alexander.levin
2017-12-13 1:57 ` [PATCH AUTOSEL for 4.9 100/100] cpuidle: fix broadcast control when broadcast can not be entered alexander.levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213015722.6722-4-alexander.levin@verizon.com \
--to=alexander.levin@verizon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrice.chotard@st.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®