From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752265AbdLMKmh (ORCPT <rfc822;w@1wt.eu>);
        Wed, 13 Dec 2017 05:42:37 -0500
Received: from mail.free-electrons.com ([62.4.15.54]:59302 "EHLO
        mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751121AbdLMKmd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Dec 2017 05:42:33 -0500
Date: Wed, 13 Dec 2017 11:42:21 +0100
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Chen-Yu Tsai <wens@csie.org>, Icenowy Zheng <icenowy@aosc.io>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Michael Trimarchi <michael@amarulasolutions.com>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        devicetree <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [PATCH] arm64: allwinner: a64: a64-olinuxino: add usb otg
Message-ID: <20171213104221.zrpwlayahzd7m4fh@flea.lan>
References: <1513058169-25516-1-git-send-email-jagan@amarulasolutions.com>
 <20171212081335.3qkqcofdbcfuu5zh@flea.lan>
 <CAMty3ZDEhXjHTE4WsJK8=yAayuR=qvJQaZEjGq=LDS6Y4V7RFw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="66nrxg6x7bqp4gia"
Content-Disposition: inline
In-Reply-To: <CAMty3ZDEhXjHTE4WsJK8=yAayuR=qvJQaZEjGq=LDS6Y4V7RFw@mail.gmail.com>
User-Agent: NeoMutt/20171027
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--66nrxg6x7bqp4gia
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 12, 2017 at 02:57:01PM +0530, Jagan Teki wrote:
> On Tue, Dec 12, 2017 at 1:43 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Hi,
> >
> > On Tue, Dec 12, 2017 at 11:26:09AM +0530, Jagan Teki wrote:
> >> Add usb otg support for a64-olinuxino board,
> >> - USB0-ID connected with PH9
> >> - USB0-VBUSDET connected with PH6
> >> - USB-DRVVBUS controlled by N_VBUSEN pin from PMIC
> >>
> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> >
> > How was this tested? Did you test the OTG part, or only the peripheral
> > part?
>=20
> Yes peripheral.

Please test the switching between host and peripheral then, and the
same comment applies to your bananapi-m64.

Thanks!
Maxime

--=20
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

--66nrxg6x7bqp4gia
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAloxBAkACgkQ0rTAlCFN
r3SRihAAgtFHxPeU9rvqLf4skp8oMFwczrCLLBPjeTyJc5dn9Nu/vcCUXOZvP+DX
iR0rAfNgJeY2EHZCaQwNwE30qsDMEZp3asQ5VmZimlFxlwZZu5IAtCc7oaLffVNm
1B0J/LOo60bbb1pZfiITpEb0Btbk/3cXhDKboT+EjV4fIiY/p0jPU4ckjvYp0sit
x1B9HNqUOf/G2GzTg15ioeH5mbYrYow3DmeZkybbqDrSTQfltQcXTu3YCwg1LwDs
gLT8wfb8Lpanl0ivlZJ/f7ty+aXQAgbOcjfRIwEUhqF9DefG9Baz93Q7yl5jiDma
aQX9c/G1oRH1DSVAHz4KEOU3BkK4DVZTK4gZ3pTHWoCdxdVVEJR7wY54l7GtVSZa
31PpCMrbtHYa8xEfNGQMgvtVZiXoyFxBFhYJ7iLpaK8Vo6ZvQiROo73kK7PJqC1Z
fqHDG9cRfVyO9VboidNM5HHM2+N8+2U+LBY9to2VMRRF/ghEwAgiwr/qfVJwEnQu
G9ZhAfEGF+hENdljxZyi2tHV0SKGwbH0Hbqntq3sJyPF2MUU0S414gi4ZunboP7d
3Mkm1kzA9ywR+RV5t3PmT+zlou9svEaqHY/H/qXoQyOcvr85wQqkxgWhiU4PuzgS
lV5jj1i4/qZH0FMqIEW6GzcHT44cDi3XGSJgSL00YvCcM9dyqEo=
=q5Bp
-----END PGP SIGNATURE-----

--66nrxg6x7bqp4gia--