From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752873AbdLMAhA (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 19:37:00 -0500
Received: from ozlabs.org ([103.22.144.67]:45697 "EHLO ozlabs.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752819AbdLMAg7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 19:36:59 -0500
Date: Wed, 13 Dec 2017 11:36:57 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Michal Hocko <mhocko@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm, hugetlbfs: include mm.h for vm_operations_struct
Message-ID: <20171213113657.6a4640ec@canb.auug.org.au>
In-Reply-To: <CAPcyv4iQWzTkrayubb32CNrYqOV77-hAC_JajZpQ0pmzoXuE+A@mail.gmail.com>
References: <20171211162243.233177-1-arnd@arndb.de>
        <20171212074722.GG4779@dhcp22.suse.cz>
        <CAPcyv4iQWzTkrayubb32CNrYqOV77-hAC_JajZpQ0pmzoXuE+A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Dan,

On Tue, 12 Dec 2017 00:05:08 -0800 Dan Williams <dan.j.williams@intel.com> wrote:
>
> On Mon, Dec 11, 2017 at 11:47 PM, Michal Hocko <mhocko@kernel.org> wrote:
> > On Mon 11-12-17 17:21:27, Arnd Bergmann wrote:  
> >> The infiniband umem code causes a build failure in some configurations:
> >>
> >> In file included from drivers/infiniband/core/umem_odp.c:41:0:
> >> include/linux/hugetlb.h: In function 'vma_kernel_pagesize':
> >> include/linux/hugetlb.h:262:32: error: dereferencing pointer to incomplete type 'const struct vm_operations_struct'
> >>
> >> Including the header file that defines the structure is sufficient to
> >> avoid this.
> >>
> >> Fixes: ac9284a6b670 ("mm, hugetlbfs: introduce ->pagesize() to vm_operations_struct")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>  
> >
> > I've tried to do the same but the compilation failed for other
> > arches/configs. See http://lkml.kernel.org/r/20171210113715.GE20234@dhcp22.suse.cz  
> 
> Andrew, Stephen, please drop this ->pagesize() patch out of -mm and
> -next. I'll circle back once I have this include dependency fixed up.
> Thanks for the reports and sorry for the noise.

I have removed commits:

  ac9284a6b670 ("mm, hugetlbfs: introduce ->pagesize() to vm_operations_struct")
  d8115c6f55a0 ("device-dax: implement ->pagesize() for smaps to report MMUPageSize")

from my copy of the mmotm tree from today.

-- 
Cheers,
Stephen Rothwell