mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, David Ahern <dsahern@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] perf tools: Fix swap for samples with raw data
Date: Wed, 13 Dec 2017 13:36:34 +0100	[thread overview]
Message-ID: <20171213123634.GA14376@krava> (raw)
In-Reply-To: <20171213123358.GR3958@kernel.org>

On Wed, Dec 13, 2017 at 09:33:58AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Nov 29, 2017 at 07:43:46PM +0100, Jiri Olsa escreveu:
> > The fix is basically to swap back the raw data if different
> > endianity is detected.
>  
> > +++ b/tools/perf/util/evsel.c
> > @@ -36,6 +36,7 @@
> >  #include "trace-event.h"
> >  #include "stat.h"
> > +#include "memswap.h"
> 
> > @@ -2131,14 +2132,27 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event,
> >  	if (type & PERF_SAMPLE_RAW) {
> 
> > +		if (swapped)
> > +			mem_bswap_64((void *) array, data->raw_size);
> > +
> 
> 
> you forgot to add util/memswap.c to tools/perf/util/python-ext-sources,
> breaking 'perf test python'.
> 
> Please run 'perf test' before sending pull requests :-)
> 

ouch ;-)

> Fixed it this time.

thanks,
jirka

  reply	other threads:[~2017-12-13 12:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 18:43 Jiri Olsa
2017-11-29 19:02 ` Steven Rostedt
2017-12-11 20:08 ` Arnaldo Carvalho de Melo
2017-12-13 12:33 ` Arnaldo Carvalho de Melo
2017-12-13 12:36   ` Jiri Olsa [this message]
2017-12-28 15:33 ` [tip:perf/core] perf evsel: " tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171213123634.GA14376@krava \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome