From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, Zi Yan <zi.yan@cs.rutgers.edu>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Reale <ar@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/3] mm, numa: rework do_pages_move
Date: Wed, 13 Dec 2017 15:47:31 +0300 [thread overview]
Message-ID: <20171213124731.hmg4r5m3efybgjtx@node.shutemov.name> (raw)
In-Reply-To: <20171213121703.GD25185@dhcp22.suse.cz>
On Wed, Dec 13, 2017 at 01:17:03PM +0100, Michal Hocko wrote:
> On Wed 13-12-17 15:07:33, Kirill A. Shutemov wrote:
> [...]
> > The approach looks fine to me.
> >
> > But patch is rather large and hard to review. And how git mixed add/remove
> > lines doesn't help too. Any chance to split it up further?
>
> I was trying to do that but this is a drop in replacement so it is quite
> hard to do in smaller pieces. I've already put the allocation callback
> cleanup into a separate one but this is about all that I figured how to
> split. If you have any suggestions I am willing to try them out.
"git diff --patience" seems generate more readable output for the patch.
> > One nitpick: I don't think 'chunk' terminology should go away with the
> > patch.
>
> Not sure what you mean here. I have kept chunk_start, chunk_node, so I
> am not really changing that terminology
We don't really have chunks anymore, right? We still *may* have per-node
batching, but..
Maybe just 'start' and 'current_node'?
--
Kirill A. Shutemov
next prev parent reply other threads:[~2017-12-13 12:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 12:48 [RFC PATCH] mm: unclutter THP migration Michal Hocko
2017-12-07 14:10 ` Zi Yan
2017-12-07 14:34 ` Michal Hocko
2017-12-08 16:15 ` [RFC PATCH 0/3] " Michal Hocko
2017-12-08 16:15 ` [RFC PATCH 1/3] mm, numa: rework do_pages_move Michal Hocko
2017-12-13 12:07 ` Kirill A. Shutemov
2017-12-13 12:17 ` Michal Hocko
2017-12-13 12:47 ` Kirill A. Shutemov [this message]
2017-12-13 14:10 ` Michal Hocko
2017-12-13 14:27 ` Kirill A. Shutemov
2017-12-13 14:39 ` Michal Hocko
2017-12-14 15:35 ` Kirill A. Shutemov
2017-12-15 9:28 ` Michal Hocko
2017-12-15 9:51 ` Kirill A. Shutemov
2017-12-15 9:57 ` Michal Hocko
2018-01-02 11:25 ` Anshuman Khandual
2018-01-02 12:12 ` Michal Hocko
2018-01-03 3:11 ` Anshuman Khandual
2018-01-03 8:42 ` Anshuman Khandual
2018-01-03 8:58 ` Michal Hocko
2018-01-03 9:36 ` Anshuman Khandual
2018-01-03 9:52 ` Michal Hocko
2017-12-08 16:15 ` [RFC PATCH 2/3] mm, migrate: remove reason argument from new_page_t Michal Hocko
2017-12-27 2:12 ` Zi Yan
2017-12-29 11:32 ` Michal Hocko
2017-12-08 16:15 ` [RFC PATCH 3/3] mm: unclutter THP migration Michal Hocko
2017-12-13 12:20 ` Kirill A. Shutemov
2017-12-27 2:19 ` Zi Yan
2017-12-29 11:36 ` Michal Hocko
2017-12-29 15:45 ` Zi Yan
2017-12-31 9:07 ` Michal Hocko
2017-12-31 13:09 ` Zi Yan
2017-12-19 12:07 ` [RFC PATCH 0/3] " Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213124731.hmg4r5m3efybgjtx@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=ar@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=vbabka@suse.cz \
--cc=zi.yan@cs.rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®