From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753011AbdLMNMK (ORCPT ); Wed, 13 Dec 2017 08:12:10 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:40182 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175AbdLMNMJ (ORCPT ); Wed, 13 Dec 2017 08:12:09 -0500 X-Google-Smtp-Source: ACJfBoshiA1Jlpf11Eo2wJ+k4B4haoz9aTevSievsW3jXREKGuNszsKf3njrivSUQQwCZJaPICRZng== Date: Wed, 13 Dec 2017 16:12:05 +0300 From: "Kirill A. Shutemov" To: Andy Lutomirski Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov , Brian Gerst , David Laight , Kees Cook , Peter Zijlstra Subject: Re: [PATCH PTI v3 03/10] x86/pti/64: Fix ESPFIX64 user mapping Message-ID: <20171213131205.adxjdggby7qpv22q@node.shutemov.name> References: <5eafbf867b587032f322898953d550d5bcaf751b.1513035461.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5eafbf867b587032f322898953d550d5bcaf751b.1513035461.git.luto@kernel.org> User-Agent: NeoMutt/20171208 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 12, 2017 at 07:56:38AM -0800, Andy Lutomirski wrote: > The ESPFIX64 user mapping belongs in pti.c just like all the other > user mappings. Move it there and make it work correctly while we're > at it. > > Signed-off-by: Andy Lutomirski Acked-by: Kirill A. Shutemov BTW, why do we open-code p?d_alloc() in pti_user_pagetable_walk_*()? It seems unnecessary and potentially bogus: see smp_wmb() in __p?d_alloc() helpers. -- Kirill A. Shutemov